Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactorings for rustc_codegen_ssa #56108

Open
5 of 10 tasks
bjorn3 opened this issue Nov 20, 2018 · 4 comments
Open
5 of 10 tasks

Refactorings for rustc_codegen_ssa #56108

bjorn3 opened this issue Nov 20, 2018 · 4 comments
Labels
A-codegen Area: Code generation A-cranelift Things relevant to the [future] cranelift backend A-gcc Things relevant to the [future] GCC backend C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@bjorn3
Copy link
Member

bjorn3 commented Nov 20, 2018 •
edited
Loading

This is a list of things I noticed in rustc_codegen_{utils,ssa} which I did like to be changed.

Edit:

Edit: update for current status
@bjorn3
Copy link
Member Author

bjorn3 commented Nov 20, 2018

cc @eddyb

@eddyb
Copy link
Member

eddyb commented Nov 20, 2018

I agree with all of these.

There are also comments on #55627 that were left unaddressed, to avoid bitrot, that could be done now.

cc @denismerigoux @sunfishcode @michaelwoerister

@bjorn3 bjorn3 mentioned this issue Nov 24, 2018
Merged
bors added a commit that referenced this issue Dec 2, 2018
@bors
Auto merge of #56198 - bjorn3:cg_ssa_refactor, r=eddyb
21f2684 
Refactor rustc_codegen_ssa

cc #56108 (not all things are done yet)

This removes an unsafe method from cg_ssa.

r? @eddyb
cc @sunfishcode
@jonas-schievink jonas-schievink added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-codegen Area: Code generation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 27, 2019
@bjorn3
Copy link
Member Author

bjorn3 commented Apr 17, 2019

The following comments from #55627 by @eddyb likely still need to be addressed (none confirmed yet, because of the amount)

@bjorn3 bjorn3 mentioned this issue Dec 3, 2019
Closed
@bjorn3
Copy link
Member Author

bjorn3 commented Mar 12, 2020 •
edited
Loading

@rustbot modify labels:+A-cranelift

@rustbot rustbot added the A-cranelift Things relevant to the [future] cranelift backend label Mar 12, 2020
@bjorn3 bjorn3 added the A-gcc Things relevant to the [future] GCC backend label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation A-cranelift Things relevant to the [future] cranelift backend A-gcc Things relevant to the [future] GCC backend C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eddyb @jonas-schievink @bjorn3 @rustbot