Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for Box::leak #46179

Closed
Centril opened this issue Nov 22, 2017 · 5 comments
Closed

Tracking issue for Box::leak #46179

Centril opened this issue Nov 22, 2017 · 5 comments
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC

Comments

@Centril
Copy link
Contributor

Centril commented Nov 22, 2017 •
edited
Loading

#![feature(box_leak)]

Implemented in #45881.
@Centril Centril mentioned this issue Nov 22, 2017
Merged
@frewsxcv frewsxcv added B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC labels Nov 22, 2017
@Centril
Copy link
Contributor Author

Centril commented Dec 29, 2017

Dumping this link here for future reference: https://github.com/search?utf8=%E2%9C%93&q=leak+extension%3A.rs+language%3ARust&type=Code&ref=advsearch&l=Rust&l=

Centril added a commit to Centril/rust that referenced this issue Feb 10, 2018
@Centril
stabilize (version: 1.26.0) Box::leak, cc rust-lang#46179
467b5cf
@Centril Centril mentioned this issue Feb 10, 2018
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Feb 24, 2018
@Manishearth
Rollup merge of rust-lang#48110 - Centril:stabilize/box_leak, r=alexc…
dd890d8 
…richton

Stabilize Box::leak

Stabilizes the following:
+ `Box::leak` (`box_leak`, in nightly since 2017-11-23)

cc rust-lang#46179

 r? @rust-lang/libs
@Centril
Copy link
Contributor Author

Centril commented Mar 18, 2018

Closing since Box::leak is stable in nightly and will make its way to stable in 1.26.0.

@Centril Centril closed this as completed Mar 18, 2018
@Gankra
Copy link
Contributor

Gankra commented May 8, 2018

I was confused why this was allowed to stabilize, but it appears that the bug that made this API unsound was fixed?

@Centril
Copy link
Contributor Author

Centril commented May 9, 2018

@gankro https://play.rust-lang.org/?gist=66d0329787975630e4f0cc62da61ed46&version=stable&mode=debug

The dupe mechanism doesn't work anymore at least.

Should we escalate this to a new issue with P-high?

@Gankra
Copy link
Contributor

Gankra commented May 9, 2018

Nope, just leaving a historical note for anyone else who was confused. Although if anyone knows when this was fixed (and if a test was added?) that would be good to note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frewsxcv @Centril @Gankra