-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some run-pass tests fail after recent LTO/CGU changes #45103
Comments
The issue with |
Thanks for the bug report, @petrochenkov! Seems like a high priority issue. |
@petrochenkov it looks like the first test, |
@alexcrichton |
Heh yeah we also need to do something about "specialization-cross-crate-defaults.stage2-x86_64-pc-windows-gnu.run-pass.libaux", that's a huge directory name! |
Shorten some test names An immediate fix for the first issue in rust-lang#45103 r? @alexcrichton
Shorten some test names An immediate fix for the first issue in rust-lang#45103 r? @alexcrichton
Shorten some test names An immediate fix for the first issue in rust-lang#45103 r? @alexcrichton
Fixed by #45215! |
Thanks for checking! I meant to come back and test to see if this was fixed, but glad you beat me to it! |
Shorten paths to auxiliary files created by tests I'm hitting issues with long file paths to object files created by the test suite, similar to #45103 (comment). If we look at the object file path in #45103 we can see that the patch contains of few components: ``` specialization-cross-crate-defaults.stage2-x86_64-pc-windows-gnu.run-pass.libaux\specialization_cross_crate_defaults.specialization_cross_crate_defaults0.rust-cgu.o ``` => 1. specialization-cross-crate-defaults // test name, required 2. stage2 // stage disambiguator, required 3. x86_64-pc-windows-gnu // target disambiguator, required 4. run-pass // mode disambiguator, rarely required 5. libaux // suffix, can be shortened 6. specialization_cross_crate_defaults // required, there may be several libraries in the directory 7. specialization_cross_crate_defaults0 // codegen unit name, can be shortened? 8. rust-cgu // suffix, can be shortened? 9. o // object file extension This patch addresses items `4`, `5` and `8`. `libaux` is shortened to `aux`, `rust-cgu` is shortened to `rcgu`, mode disambiguator is omitted unless it's necessary (for pretty-printing and debuginfo tests, see 38d26d8) I haven't touched names of codegen units though (`specialization_cross_crate_defaults0`). Is it useful for them to have descriptive names including the crate name, as opposed to just `0` or `cgu0` or something?
Shorten paths to auxiliary files created by tests I'm hitting issues with long file paths to object files created by the test suite, similar to rust-lang/rust#45103 (comment). If we look at the object file path in rust-lang/rust#45103 we can see that the patch contains of few components: ``` specialization-cross-crate-defaults.stage2-x86_64-pc-windows-gnu.run-pass.libaux\specialization_cross_crate_defaults.specialization_cross_crate_defaults0.rust-cgu.o ``` => 1. specialization-cross-crate-defaults // test name, required 2. stage2 // stage disambiguator, required 3. x86_64-pc-windows-gnu // target disambiguator, required 4. run-pass // mode disambiguator, rarely required 5. libaux // suffix, can be shortened 6. specialization_cross_crate_defaults // required, there may be several libraries in the directory 7. specialization_cross_crate_defaults0 // codegen unit name, can be shortened? 8. rust-cgu // suffix, can be shortened? 9. o // object file extension This patch addresses items `4`, `5` and `8`. `libaux` is shortened to `aux`, `rust-cgu` is shortened to `rcgu`, mode disambiguator is omitted unless it's necessary (for pretty-printing and debuginfo tests, see rust-lang/rust@38d26d8) I haven't touched names of codegen units though (`specialization_cross_crate_defaults0`). Is it useful for them to have descriptive names including the crate name, as opposed to just `0` or `cgu0` or something?
Probably #44841, because the tests passed yesterday.
Observed on
x86_64-pc-windows-gnu
.cc @alexcrichton @michaelwoerister
Affected tests:
Errors:
The text was updated successfully, but these errors were encountered: