Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incoming is broken #4437

Closed
catamorphism opened this issue Jan 11, 2013 · 1 comment
Closed

Incoming is broken #4437

catamorphism opened this issue Jan 11, 2013 · 1 comment
Labels
I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics.
Milestone
0.6

Comments

@catamorphism
Copy link
Contributor

rustdoctest tests segfault. Whatever commit introduced the problem, it wasn't one of the last 20 that show up on the buildbot console.
@catamorphism
Copy link
Contributor Author

Narrowed down the problem to the call to vec::filter in prune_private_pass.rs. When I changed it to filtered, the problem went away. I'll file a separate bug for that. In the meantime, fixed in 0c05a6c

flip1995 pushed a commit to flip1995/rust that referenced this issue Aug 28, 2020
Fix let_and_return bad suggestion
e8d33d7 
Add a cast to the suggestion when the return expression has adjustments.
These adjustments are lost when the suggestion is applied.

This is similar to the problem in issue rust-lang#4437.

Closes rust-lang#5729
flip1995 pushed a commit to flip1995/rust that referenced this issue Aug 28, 2020
@bors
Auto merge of rust-lang#5946 - mikerite:fix-5729, r=flip1995
894581b 
Fix `let_and_return` bad suggestion

Add a cast to the suggestion when the return expression has adjustments.
These adjustments are lost when the suggestion is applied.

This is similar to the problem in issue rust-lang#4437.

Closes rust-lang#5729

changelog: Fix `let_and_return` bad suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics.
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
1 participant
@catamorphism