Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pub/priv qualifiers should be forbidden on impls #3985

Closed
catamorphism opened this issue Nov 16, 2012 · 5 comments
Closed

pub/priv qualifiers should be forbidden on impls #3985

catamorphism opened this issue Nov 16, 2012 · 5 comments
Labels
A-grammar Area: The grammar of Rust A-parser Area: The parsing of Rust source code to an AST C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Milestone
0.6

Comments

@catamorphism
Copy link
Contributor

Right now they're silently ignored.
@ghost ghost assigned catamorphism Nov 24, 2012
@cpeterso
Copy link
Contributor

@catamorphism, is this issue a dupe of issue #3452?

@catamorphism
Copy link
Contributor Author

@cpeterso - Sort of -- I think this issue supersedes #3452.

@catamorphism catamorphism mentioned this issue Jan 25, 2013
Closed
@catamorphism catamorphism mentioned this issue Feb 21, 2013
Closed
@catamorphism
Copy link
Contributor Author

Also see #3600 , which is a pending RFC

@catamorphism
Copy link
Contributor Author

As per meeting: we need to allow it on impl... impls (that aren't for a trait), but forbid it on impl for... impls (impls of a trait for a type), since trait methods already have their own visibility and such an impl just overloads them.

@catamorphism catamorphism mentioned this issue Feb 27, 2013
Closed
@pcwalton
Copy link
Contributor

Fixed

@catamorphism catamorphism removed their assignment Jun 16, 2014
RalfJung pushed a commit to RalfJung/rust that referenced this issue Oct 27, 2024
@bors
Auto merge of rust-lang#3985 - rust-lang:rustup-2024-10-22, r=RalfJung
3d9d393 
Automatic Rustup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-grammar Area: The grammar of Rust A-parser Area: The parsing of Rust source code to an AST C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
3 participants
@pcwalton @catamorphism @cpeterso