Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure still allows --disable-rustbuild #39762

Closed
binarycrusader opened this issue Feb 12, 2017 · 0 comments
Closed

configure still allows --disable-rustbuild #39762

binarycrusader opened this issue Feb 12, 2017 · 0 comments

Comments

@binarycrusader
Copy link
Contributor

As far as I know, it's no longer possible to not use rustbuild, so ./configure offering --disable-rustbuild doesn't make much sense and it still accepts it:

./configure --help|grep rustbuild
    --disable-rustbuild              don't use the rust and cargo based build system

$ ./configure --disable-rustbuild
...
configure: processing ./configure args
configure: 
configure: CFG_DISABLE_RUSTBUILD := 1 
...
configure: configured in release mode. for development consider --enable-debug
configure: 
configure: run `python ./x.py --help`
configure: 
$
frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 13, 2017
@frewsxcv
Remove '--disable-rustbuild' option from configure script.
6194a76 
Fixes rust-lang#39762.
@frewsxcv frewsxcv mentioned this issue Feb 13, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 13, 2017
@frewsxcv
Rollup merge of rust-lang#39774 - frewsxcv:no-rustbuild, r=alexcrichton
e9abf4b 
Remove '--disable-rustbuild' option from configure script.

Fixes rust-lang#39762.
@hcorion hcorion mentioned this issue Feb 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@binarycrusader