std::vec::IntoIter::as_mut_slice borrows &self, returns &mut of contents.
#39465
Labels
I-unsound
Issue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
Comments
steveklabnik
added
A-libs
I-unsound
|
Awesome! |
|
I suggest we change it to &mut and run it through crater to see the impact. We can change it or immediately deprecate it. We can make a point release or wait until 1.16. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
Feb 2, 2017
This was intended to require `&mut self`, not `&self`, otherwise it's unsound! Closes rust-lang#39465
bors
added a commit
that referenced
this issue
Feb 3, 2017
std: Fix IntoIter::as_mut_slice's signature This was intended to require `&mut self`, not `&self`, otherwise it's unsound! Closes #39465
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
Feb 3, 2017
This was intended to require `&mut self`, not `&self`, otherwise it's unsound! Closes rust-lang#39465
brson
pushed a commit
to brson/rust
that referenced
this issue
Feb 4, 2017
This was intended to require `&mut self`, not `&self`, otherwise it's unsound! Closes rust-lang#39465
brson
pushed a commit
to brson/rust
that referenced
this issue
Feb 4, 2017
This was intended to require `&mut self`, not `&self`, otherwise it's unsound! Closes rust-lang#39465
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
/u/dbauppon reddit points out that this method can be called multiple times and result in getting multiple&mut [T]of the exact same data.The text was updated successfully, but these errors were encountered: