Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc's test pass shouldn't generate calls to os::args #3938

Closed
brson opened this issue Nov 8, 2012 · 3 comments
Closed

rustc's test pass shouldn't generate calls to os::args #3938

brson opened this issue Nov 8, 2012 · 3 comments
Labels
A-syntaxext Area: Syntax extensions E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Nov 8, 2012

For maintainability, rustc::front::test it should only be generating calls into std::test, so either there should be an os::args reexport in std::test or (my preference) test_main should contain the call to os::args and there should be a separate function for executing the console test running while providing the args.

@graydon
Copy link
Contributor

graydon commented Mar 25, 2013

non-critical for 0.6, de-milestoning

@brson
Copy link
Contributor Author

brson commented Mar 25, 2013

As I see these bugs get de-milestoned I wonder how these things get milestoned in the first place. Maybe I thought it was something I would get around to, but it's clearly not important.

@catamorphism
Copy link
Contributor

This already appears to be true. Closing.

RalfJung pushed a commit to RalfJung/rust that referenced this issue Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-syntaxext Area: Syntax extensions E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

3 participants