Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in cargo-check 0.2.2 test suite in Rust 1.15 #38722

Closed
brson opened this issue Dec 30, 2016 · 3 comments
Closed

Regression in cargo-check 0.2.2 test suite in Rust 1.15 #38722

brson opened this issue Dec 30, 2016 · 3 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta.

Comments

@brson
Copy link
Contributor

brson commented Dec 30, 2016

https://github.com/rsolomo/cargo-check at d446f7865b2ac925c8e05c7129998084718c00d4

brian@ip-10-145-43-250:~/dev/cargo-check⟫ rustc +beta -Vv
rustc 1.15.0-beta.1 (d9a0f0df7 2016-12-19)
binary: rustc
commit-hash: d9a0f0df7051c603011d6b60fbdd155318fc47f3
commit-date: 2016-12-19
host: x86_64-unknown-linux-gnu
release: 1.15.0-beta.1
LLVM version: 3.9

brian@ip-10-145-43-250:~/dev/cargo-check⟫ cargo +beta test
   Compiling itoa v0.1.1
   Compiling num-traits v0.1.35
   Compiling serde v0.8.17
   Compiling dtoa v0.2.2
   Compiling serde_json v0.8.3
   Compiling cargo-check v0.2.2 (file:///mnt2/dev/cargo-check)
    Finished debug [unoptimized + debuginfo] target(s) in 12.60 secs
     Running target/debug/deps/cargo_check-7f0aeef4249df34a

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured

     Running target/debug/deps/multitarget-fd24899997c91294

running 5 tests
test multiple_targets ... FAILED
test multiple_targets_2 ... FAILED
test multiple_targets_3 ... FAILED
test multiple_targets_4 ... FAILED
test self_test ... FAILED

failures:

---- multiple_targets stdout ----
        thread 'multiple_targets' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 2, message: "No such file or directory" } }', /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/src/libcore/result.rs:837
note: Run with `RUST_BACKTRACE=1` for a backtrace.

---- multiple_targets_2 stdout ----
        thread 'multiple_targets_2' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 2, message: "No such file or directory" } }', /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/src/libcore/result.rs:837

---- multiple_targets_3 stdout ----
        thread 'multiple_targets_3' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 2, message: "No such file or directory" } }', /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/src/libcore/result.rs:837

---- multiple_targets_4 stdout ----
        thread 'multiple_targets_4' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 2, message: "No such file or directory" } }', /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/src/libcore/result.rs:837

---- self_test stdout ----
        thread 'self_test' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 2, message: "No such file or directory" } }', /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/src/libcore/result.rs:837


failures:
    multiple_targets
    multiple_targets_2
    multiple_targets_3
    multiple_targets_4
    self_test

test result: FAILED. 0 passed; 5 failed; 0 ignored; 0 measured

error: test failed

Seems likely to be rust-lang/cargo#3368

cc @rsolomo

@brson brson added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label Dec 30, 2016
alexcrichton added a commit to alexcrichton/cargo-check that referenced this issue Dec 30, 2016
Cargo's output directory structure changed slightly on beta, so this updates the
test suite to accommodate for those changes.

cc rust-lang/rust#38722
@alexcrichton
Copy link
Member

I believe this was actually rust-lang/cargo#3102, and I've submitted a fix: rsolomo/cargo-check#21

@brson
Copy link
Contributor Author

brson commented Dec 31, 2016

Thanks @alexcrichton. I suppose we should wait and see if that PR is accepted, but seems like that's all for us to do.

@rsolomo
Copy link

rsolomo commented Jan 2, 2017

Thanks for the PR. It has been merged.

@sfackler sfackler closed this as completed Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta.
Projects
None yet
Development

No branches or pull requests

4 participants