Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0373 needs to be updated to new format #35337

Closed
sophiajt opened this issue Aug 4, 2016 · 1 comment
Closed

E0373 needs to be updated to new format #35337

sophiajt opened this issue Aug 4, 2016 · 1 comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 4, 2016

From: src/test/compile-fail/issue-4335.rs

The error E0373 needs a span_note changed to a span_label and a new span_label, updating it from:

error[E0373]: closure may outlive the current function, but it borrows `v`, which is owned by the current function
  --> src/test/compile-fail/issue-4335.rs:17:17
   |
17 |     id(Box::new(|| *v))
   |                 ^^
   |
note: `v` is borrowed here
  --> src/test/compile-fail/issue-4335.rs:17:21
   |
17 |     id(Box::new(|| *v))
   |                     ^
help: to force the closure to take ownership of `v` (and any other referenced variables), use the `move` keyword, as shown:
   |     id(Box::new(move || *v))

To:

error[E0373]: closure may outlive the current function, but it borrows `v`, which is owned by the current function
  --> src/test/compile-fail/issue-4335.rs:17:17
   |
17 |     id(Box::new(|| *v))
   |                 ^^  - `v` borrowed here
   |                 |
   |                 may outlive borrowed value `v`
   |
help: to force the closure to take ownership of `v` (and any other referenced variables), use the `move` keyword, as shown:
   |     id(Box::new(move || *v))
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 4, 2016
@trixnz
Copy link
Contributor

trixnz commented Aug 5, 2016

Taking care of this one.

sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 5, 2016
eddyb added a commit to eddyb/rust that referenced this issue Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants