Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustbuild: doc-rustc overwrites search index #34800

Closed
TimNN opened this issue Jul 13, 2016 · 3 comments
Closed

rustbuild: doc-rustc overwrites search index #34800

TimNN opened this issue Jul 13, 2016 · 3 comments
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@TimNN
Copy link
Contributor

TimNN commented Jul 13, 2016 •
edited
Loading

Building the compiler docs with rustbuild overwrites the js search index of the std docs with the one from the compiler docs.

Example: https://rust-beta-doc.timnn.me/std/index.html?search=String (that is no longer live).
@alexcrichton alexcrichton added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jul 13, 2016
@alexcrichton
Copy link
Member

Hm I think that this may be a result of a little too aggressively cleaning out the doc directory, there's probably some fs::remove_dir_all which should be sequenced differently or perhaps just not run at all.

@ollie27 ollie27 mentioned this issue Dec 12, 2016
Closed
ollie27 added a commit to ollie27/rust that referenced this issue Dec 15, 2016
@ollie27
rustbuild: Stop building docs for libtest by default
c49e317 
They cause the search index from the std docs to get overwritten just like rust-lang#34800.

Part of rust-lang#38319.
@ollie27 ollie27 mentioned this issue Dec 15, 2016
Merged
bors added a commit that referenced this issue Dec 16, 2016
@bors
Auto merge of #38398 - ollie27:patch-1, r=alexcrichton
33ab83c 
rustbuild: Stop building docs for libtest by default

They cause the search index from the std docs to get overwritten just like #34800.

Part of #38319.
alexcrichton added a commit to alexcrichton/rust that referenced this issue Dec 20, 2016
@alexcrichton
Rollup merge of rust-lang#38398 - ollie27:patch-1, r=alexcrichton
2104111 
rustbuild: Stop building docs for libtest by default

They cause the search index from the std docs to get overwritten just like rust-lang#34800.

Part of rust-lang#38319.
alexcrichton pushed a commit to alexcrichton/rust that referenced this issue Dec 30, 2016
@ollie27 @alexcrichton
rustbuild: Stop building docs for libtest by default
2b450e3 
They cause the search index from the std docs to get overwritten just like rust-lang#34800.

Part of rust-lang#38319.
@ollie27 ollie27 mentioned this issue Jan 8, 2017
Merged
@ollie27
Copy link
Member

ollie27 commented Mar 12, 2017

This was fixed by #40199.

@alexcrichton
Copy link
Member

Indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @TimNN @ollie27