Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a mechanism for libcore to export privates to libstd only. #3144

Closed
bblum opened this issue Aug 8, 2012 · 1 comment
Closed

Add a mechanism for libcore to export privates to libstd only. #3144

bblum opened this issue Aug 8, 2012 · 1 comment
Labels
A-linkage Area: linking into static, shared libraries and binaries

Comments

@bblum
Copy link
Contributor

bblum commented Aug 8, 2012

There are already several things either (a) in libcore that should be in libstd or (b) inappropriately exported from libcore.

A mechanism for std to be a "friend" of core would solve both of these without making libcore grow tremendously large. I'm not sure how crate metadata works, but I could imagine writing export mod in a crate file would export the module publically, while all other modules do get exported, only privately.
@bblum
Copy link
Contributor Author

bblum commented Aug 21, 2012

We decided not to do this, and instead just document them all as unsafe.

@bblum bblum closed this as completed Aug 21, 2012
@ghost ghost assigned bblum Aug 21, 2012
This was referenced Aug 21, 2012
Closed
Closed
@bblum bblum removed their assignment Jun 16, 2014
bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
@nrc
Merge pull request rust-lang#3144 from otavio/issues-3143
bdd4049 
 cargo-fmt: Fix splitting of targets across editions
RalfJung pushed a commit to RalfJung/rust that referenced this issue Nov 4, 2023
@bors
Auto merge of rust-lang#3144 - RalfJung:supported, r=oli-obk
5f3d81a 
add aarch64-apple-darwin to list of supported targets

I did not realize that aarch64-apple-darwin is a tier 2 target. We are testing it properly, even on rustc CI, so we might as well list it as fully supported here.
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@celinval
Upgrade toolchain to nightly-2024-04-15 (rust-lang#3144)
b9bd7a8 
Related changes:
  - rust-lang#118310:
    Add `Ord::cmp` for primitives as a `BinOp` in MIR
  - rust-lang#120131:
    Add support to `Pat` pattern type
  - rust-lang#122935:
    Rename CastKind::PointerWithExposedProvenance
  - rust-lang#123097:
    Adapt to changes to local_def_path_hash_to_def_id

Resolves rust-lang#3130, rust-lang#3142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linkage Area: linking into static, shared libraries and binaries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bblum