Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non exported paths can be imported from other crates if they are reachable #3137

Closed
msullivan opened this issue Aug 7, 2012 · 2 comments
Closed

Non exported paths can be imported from other crates if they are reachable #3137

msullivan opened this issue Aug 7, 2012 · 2 comments
Labels
A-linkage Area: linking into static, shared libraries and binaries

Comments

@msullivan
Copy link
Contributor

The metadata and resolve3 don't distinguish between things in the metadata because they were actually exported and things that are in the metadata because they were reachable. This means that a lot of things can be imported from other crates that weren't actually exported.

The solution is probably to tag whether something is exported in the metadata and check that in resolve3.
@ghost ghost assigned msullivan Aug 7, 2012
@msullivan msullivan mentioned this issue Aug 7, 2012
Closed
@nikomatsakis
Copy link
Contributor

Not critical for 0.6; removing milestone

@catamorphism
Copy link
Contributor

This is fixed.

bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
@topecongiro
Add a test for rust-lang#3137
2d04871
RalfJung pushed a commit to RalfJung/rust that referenced this issue Oct 25, 2023
@bors
Auto merge of rust-lang#3137 - RalfJung:data-race, r=oli-obk
a15eb7e 
Detect mixed-size and mixed-atomicity non-synchronized accesses

Fixes rust-lang/miri#2303
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@tautschnig
Remove is-a-parameter from gen_stack_variable (rust-lang#3137)
e906cde 
A function-local variable cannot at the same time be a parameter. Alas,
all uses of gen_stack_variable passed in `false` for `is_param`, so this
wasn't making a difference anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linkage Area: linking into static, shared libraries and binaries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nikomatsakis @msullivan @catamorphism