-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non copyable values captured by fn~ closures can be copied #2828
Comments
The problem is that send used to be a subset of copy. This was changed but it sounds like |
This appears to have fixed itself, hallelujah! In 8255aa1 I checked in the test case. |
I don't think it's really fixed. If you modify the test case to include a "move" capture clause, it still reproduces:
The proper fix is the work on closure bounds I did not get to for 0.5! |
Oops! Bumping to 0.6, then. |
Tree Borrows: improved diagnostics Better diagnostics for Tree Borrows violations. - Shows where the conflicting tags (the one that was accessed and the one that had a permission or protector that caused UB) were reborrowed, which is more readable than only `<TAG>` - Shows a small history of what happened for the faulty tag to get there (which lines caused it to lose read/write permissions) - Explains permissions and transitions in natural language (e.g. "does not have read permissions" instead of "is Disabled") Not perfect, but at least testing TB will be less confusing. Lack of range information from `RangeMap` makes selection of relevant events nontrivial: we reconstruct history from knowledge of `(initial, final)` and `(offset, pi, p'i)` so that `initial -> final = p1 -> p1' = p2 -> p2' = p3 -> ... = final `
Tree Borrows: improved diagnostics Better diagnostics for Tree Borrows violations. - Shows where the conflicting tags (the one that was accessed and the one that had a permission or protector that caused UB) were reborrowed, which is more readable than only `<TAG>` - Shows a small history of what happened for the faulty tag to get there (which lines caused it to lose read/write permissions) - Explains permissions and transitions in natural language (e.g. "does not have read permissions" instead of "is Disabled") Not perfect, but at least testing TB will be less confusing. Lack of range information from `RangeMap` makes selection of relevant events nontrivial: we reconstruct history from knowledge of `(initial, final)` and `(offset, pi, p'i)` so that `initial -> final = p1 -> p1' = p2 -> p2' = p3 -> ... = final `
Update the CI to use MacOS 12 instead of MacOS 11. I'm leaving this as a draft until I can validate that the bundle works on MacOS 11. Resolves rust-lang#2827
The following program compiles and runs and will run the destructor twice:
The text was updated successfully, but these errors were encountered: