Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad span assigned to continue keyword #28105

Closed
marcusklaas opened this issue Aug 30, 2015 · 3 comments
Closed

Bad span assigned to continue keyword #28105

marcusklaas opened this issue Aug 30, 2015 · 3 comments

Comments

@marcusklaas
Copy link
Contributor

The break expression span contains its keyword, but the one for continue does not: http://is.gd/phbWGX

cc https://github.com/nrc/rustfmt/issues/184

@nagisa
Copy link
Member

nagisa commented Aug 30, 2015

I’d say its the break span that’s more wrong here. The error message is about the label after all.

@marcusklaas
Copy link
Contributor Author

I only used the labels to generate an error message which shows the span. Even without labels, the span is incorrect.

I could agree that the highlighted part in the error message should not include the keyword, but that's an other issue in my mind.

@nagisa
Copy link
Member

nagisa commented Aug 30, 2015

Oh indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants