Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exporting impl from root of crate causes ICE #2472

Closed
nikomatsakis opened this issue May 31, 2012 · 1 comment
Closed

exporting impl from root of crate causes ICE #2472

nikomatsakis opened this issue May 31, 2012 · 1 comment
Labels
A-resolve Area: Name resolution I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics.
Milestone
0.4

Comments

@nikomatsakis
Copy link
Contributor

I had an impl that I was exporting from the root of a crate, and whenever I linked against this crate I ran into an ICE somewhere in resolve. Sorry, no test case.
brson added a commit that referenced this issue Aug 15, 2012
@brson
Add test for #2472
83b42c8
@brson
Copy link
Contributor

brson commented Aug 15, 2012

Seems to work now.

@brson brson closed this as completed Aug 15, 2012
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 22, 2022
@bors
Auto merge of rust-lang#2472 - RalfJung:backtrace, r=RalfJung
aa53f3f 
fix RUSTC_BACKTRACE always being set

I kept wondering why Miri programs, whenever isolation is disabled, behave as if RUSTC_BACKTRACE was set. Finally I realized it's because some early rustc setup code sets that env var, and that is then propagated to the interpreted program.

So fix that by taking a copy of the environment before any rustc setup, and use that copy as the basis for what is provided to the interpreted program.
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@zhassan-aws
Avoid an unnecssary suffix to the goto filename (rust-lang#2472)
5d2485e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-resolve Area: Name resolution I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics.
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@brson @nikomatsakis