Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

view items should support attributes and conditional compilation #2357

Closed
brson opened this issue May 5, 2012 · 7 comments
Closed

view items should support attributes and conditional compilation #2357

brson opened this issue May 5, 2012 · 7 comments
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) A-grammar Area: The grammar of Rust C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented May 5, 2012

I've jumped through hoops a few times trying to write use statements conditionalized by platform.
@brson brson closed this as completed May 5, 2012
@brson
Copy link
Contributor Author

brson commented May 5, 2012

I've changed my mind about this.

@marijnh
Copy link
Contributor

marijnh commented May 8, 2012

Why? With this issue in mind, I just implemented attributes for view items (I was messing with the view item parsing code anyway to add support for pub imports). But supporting conditional compilation for view items seems like a no-brainer -- it's useful, and unproblematic.

@brson brson reopened this May 8, 2012
@brson
Copy link
Contributor Author

brson commented May 8, 2012

I only changed my mind because I had a reasonable workaround and didn't want to bother with an RFC.

marijnh added a commit that referenced this issue May 8, 2012
@marijnh
Support visibility modifiers and attributes on view items
96a159a 
Issue #1893
Tangentially, issue #2357
@graydon
Copy link
Contributor

graydon commented May 9, 2012

Yeah, it seems reasonable to me too.

@jdm
Copy link
Contributor

jdm commented Jul 9, 2012

Is this complete, or is conditional compilation still required?

@brson
Copy link
Contributor Author

brson commented Jul 9, 2012

The configuration (conditional compilation) pass still ignores view item attributes.

brson added a commit that referenced this issue Jul 9, 2012
@brson
rustc: Conditionally compile view items. #2357
b7a418e
@brson
Copy link
Contributor Author

brson commented Jul 9, 2012

Fixed.

@brson brson closed this as completed Jul 9, 2012
RalfJung pushed a commit to RalfJung/rust that referenced this issue Dec 24, 2022
@bors
Auto merge of rust-lang#2357 - DebugSteven:epoll_create1-shim, r=oli-obk
7893132 
implement minimal epoll_create1 shim

Implements minimal shim for rust-lang#602
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2357 - DebugSteven:epoll_create1-shim, r=oli-obk
205ab4f 
implement minimal epoll_create1 shim

Implements minimal shim for rust-lang#602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) A-grammar Area: The grammar of Rust C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@graydon @jdm @marijnh @brson