You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A very old -- but still accurate -- FIXME in std::bitv suggests rewriting the module to use recursive object types -- aka "classes". Now that we have classes, it's possible to do this.
I'd enjoy working on this, but if someone else wants to try out classes, that would be cool too.
The text was updated successfully, but these errors were encountered:
Are you by any chance getting Invalid read/write errors during the test suite?
I have added some code to std::bitv for #2964 and I am now getting such errors, and also some assertion failures during the tests I have added. Curiously enough the code/tests I have added seem to work correctly outside of the std::bitv module - so I think something weird is happening here.
@Dretch No -- I'm getting wrong results. It's not too surprising that you could get different behavior inside and outside the bitv module, as the compiler does some things differently for inside-the-crate vs. outside-the-crate things (though if it changes observable behavior, that's a bug).
rustup; ptr atomics
Adds support for the operations added in rust-lang#96935.
I made the pointer-binops always return the provenance of the *left* argument; `@thomcc` I hope that is what you intended. I have honestly no idea if it has anything to do with what LLVM does...
I also simplified our pointer comparison code while I was at it -- now that *all* comparison operators support wide pointers, we can unify those branches.
A very old -- but still accurate -- FIXME in std::bitv suggests rewriting the module to use recursive object types -- aka "classes". Now that we have classes, it's possible to do this.
I'd enjoy working on this, but if someone else wants to try out classes, that would be cool too.
The text was updated successfully, but these errors were encountered: