Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on CFG_DISABLE_DEBUG by default #22390

Closed
pcwalton opened this issue Feb 16, 2015 · 4 comments
Closed

Turn on CFG_DISABLE_DEBUG by default #22390

pcwalton opened this issue Feb 16, 2015 · 4 comments
Assignees
@brson
Labels
I-compiletime Issue: Problems and improvements with respect to compile times. P-medium Medium priority
Milestone
1.0

Comments

@pcwalton
Copy link
Contributor

There's no reason to have debug_assert! enabled for most of our binaries. This is probably a lot of the reason behind our benchmark problems!

I nominate for P-high.
@pcwalton pcwalton added I-slow Issue: Problems and improvements with respect to performance of generated code. A-build A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) labels Feb 16, 2015
@pnkfelix
Copy link
Member

cc #17081

cc rust-lang/rfcs#563

@nikomatsakis
Copy link
Contributor

cc #22492

@pnkfelix
Copy link
Member

P-high, 1.0 polish.

@pnkfelix pnkfelix added the P-medium Medium priority label Feb 19, 2015
@pnkfelix pnkfelix added this to the 1.0 milestone Feb 19, 2015
@michaelwoerister michaelwoerister removed the A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) label Feb 26, 2015
@michaelwoerister
Copy link
Member

Removed A-debuginfo. This is a build system issue.

@emberian emberian added I-compiletime Issue: Problems and improvements with respect to compile times. and removed I-slow Issue: Problems and improvements with respect to performance of generated code. labels Mar 25, 2015
@brson brson self-assigned this Apr 7, 2015
@brson brson mentioned this issue Apr 8, 2015
Closed
Manishearth added a commit to Manishearth/rust that referenced this issue Apr 9, 2015
@Manishearth
Rollup merge of rust-lang#24205 - brson:debug, r=alexcrichton
b43c957 
 This makes the default configuration fully optimized, with no debugging options, no llvm asserts, renames --enable-debug to --enable-debug-assertions, and adds --enable-debug as a blanket option that toggles various things, per rust-lang#17665. It does not add a `--enable-release` flag since that would be a no-op.

cc @nrc

Fixes rust-lang#22390
Fixes rust-lang#17081
Partially addresses rust-lang#17665
bors added a commit that referenced this issue Apr 9, 2015
@bors
Auto merge of #24205 - brson:debug, r=alexcrichton
6b95d8b 
This makes the default configuration fully optimized, with no debugging options, no llvm asserts, renames --enable-debug to --enable-debug-assertions, and adds --enable-debug as a blanket option that toggles various things, per #17665. It does not add a `--enable-release` flag since that would be a no-op.

cc @nrc

Fixes #22390
Fixes #17081
Partially addresses #17665
@bors bors closed this as completed in 2dffe78 Apr 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brson brson

Labels
I-compiletime Issue: Problems and improvements with respect to compile times. P-medium Medium priority
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Fully optimize by default brson/rust
6 participants
@brson @nikomatsakis @pcwalton @pnkfelix @emberian @michaelwoerister