Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect naming in std::failure #22306

Closed
brson opened this issue Feb 13, 2015 · 2 comments · Fixed by #22347
Closed

Incorrect naming in std::failure #22306

brson opened this issue Feb 13, 2015 · 2 comments · Fixed by #22347
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Feb 13, 2015

Module should be named panicking to match core, on_fail should be on_panic.
@brson brson added A-libs E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Feb 13, 2015
@iKevinY
Copy link
Contributor

iKevinY commented Feb 14, 2015

Took a shot at this in iKevinY/rust@1e01f7f470f1d79be710d546ab25426fcede59f9, but I wanted to verify here to make sure I interpreted the issue correctly before opening a PR. At a glance, does this look alright? (make check still passes.)

@brson
Copy link
Contributor Author

brson commented Feb 14, 2015

@iKevinY Yes looks right. Thanks!

@iKevinY iKevinY mentioned this issue Feb 14, 2015
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this issue Feb 15, 2015
@steveklabnik
Rollup merge of rust-lang#22347 - iKevinY:std-lib-panicking, r=brson
3ce2e0d 
Rename `libstd/failure.rs` to `libstd/panicking.rs` and `on_fail` to `on_panic`. Closes rust-lang#22306.
Manishearth added a commit to Manishearth/rust that referenced this issue Feb 15, 2015
@Manishearth
Rollup merge of rust-lang#22347 - iKevinY:std-lib-panicking, r=brson
e5659ea 
 Rename `libstd/failure.rs` to `libstd/panicking.rs` and `on_fail` to `on_panic`. Closes rust-lang#22306.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename std::failure to std::panicking
2 participants
@brson @iKevinY