-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature-gate unsafe_no_drop_flag
#22173
Comments
nominating, seems 1.0 beta to me. |
(subtask of #5016, but gets higher priority due to (more) semantic visibility) |
See RFC 320, "Non-zeroing dynamic drops." Fix rust-lang#22173 [breaking-change]
This feature gate doesn't seem to be required as of alpha 2. The following compiles without issue: #[unsafe_no_drop_flag]
struct Foo;
impl Drop for Foo {
fn drop(&mut self) {
println!("Dropping");
}
}
fn main() { } |
it seems like PR #22364 may have accidentally have removed the gating of (That's what I deserve for not including a regression test on this.) I think I know how to fix this. (And I will look into making sure all of the feature-gated things have tests.) |
…o_drop_flag, r=alexcrichton Turn `unsafe_no_drop_flag` back into a gated-feature. Fix rust-lang#22173
As part of non-zeroing dynamic drop (RFC 320), we need to feature-gate
unsafe_no_drop_flag
so that users do not come to rely on its unstable semantics when we release 1.0.The text was updated successfully, but these errors were encountered: