Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/test/run-pass/html-literals.rs is ignored #20673

Closed
alexcrichton opened this issue Jan 7, 2015 · 2 comments
Closed

src/test/run-pass/html-literals.rs is ignored #20673

alexcrichton opened this issue Jan 7, 2015 · 2 comments
Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@alexcrichton
Copy link
Member

With the new macro rules (#20563) this test had to be ignored.
@alexcrichton alexcrichton added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jan 7, 2015
@alexcrichton
Copy link
Member Author

cc @cmr

@emberian emberian self-assigned this Jan 7, 2015
@emberian
Copy link
Member

emberian commented Jan 7, 2015

If this is fixed at all, it will be by integrating detailed FIRST sets into the check, but I'm not sure we want to support something like this with macro_rules (I know @nikomatsakis has opinions about this).

@emberian emberian added the A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) label Jan 7, 2015
@emberian emberian removed their assignment Mar 26, 2015
@steveklabnik steveklabnik mentioned this issue Jun 12, 2015
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this issue Jun 12, 2015
@steveklabnik
Re-enable html literals test
49d8573 
It's now passing again.

Fixes rust-lang#20673
bors added a commit that referenced this issue Jun 13, 2015
@bors
Auto merge of #26250 - steveklabnik:remove_html_literals_test, r=alex…
5f3233f 
…crichton

This test now works again

Fixes #20673

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @emberian