Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out the common code in configure script #17854

Closed
brson opened this issue Oct 7, 2014 · 2 comments
Closed

Factor out the common code in configure script #17854

brson opened this issue Oct 7, 2014 · 2 comments

Comments

@brson
Copy link
Contributor

brson commented Oct 7, 2014

Rust's configure script contains 4 years of accumulated knowledge, mostly around command line parsing and platform detection. We've copied parts of this script to Cargo's configure script, install.sh and rustup.sh. It would be nice to not duplicate this logic since the implementation of each drifts over time.

cc #16456

@brson brson added the A-build label Oct 7, 2014
@steveklabnik
Copy link
Member

Small update: @alexcrichton 's work to build with Cargo still uses the configure script, so this will still be valid even after that lands https://github.com/alexcrichton/rust/blob/build-via-cargo/configure

No change really, otherwise.

@alexcrichton
Copy link
Member

This script is now being trimmed down with rustbuild, so I don't think this is relevant any more

lnicola pushed a commit to lnicola/rust that referenced this issue Aug 13, 2024
fix: Trailing excess comma in "Convert to named struct" assist

Fixes rust-lang#17854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants