Get rid of redundancy in type errors

[kmcallister]

error: mismatched types: expected `uint`, found `int` (expected uint, found int)  

I guess the parenthetical tells you about the outermost type constructors of the mismatch, e.g. "expected uint, found &-ptr". But in many cases it's redundant. We should get rid of the parenthetical in cases where it's useless, and then add some explanatory text about what it's trying to tell you.

[alexispurslane]

So maybe it should check to see if the parenthetical is exactly the same, and not print it if it is?

[rclanan]

I took a look at this and I am not sure what the fix would be. To save time for someone else the two locations that I identified are below:

• Here is the actual location of the format where the parenthesis are being added and if we wanted to remove them all together we would need to do a check here to change the string getting passed into format.
  https://github.com/rust-lang/rust/blob/master/src/librustc/middle/typeck/infer/error_reporting.rs#L374
• If we wanted to add explanatory text about what it's trying to tell us instead, here might be the place to do that as this is where the actual string is getting defined.
  

  rust/src/librustc/middle/ty.rs

  Line 3819 in 222ae8b

  terr_sigil_mismatch(values) => {

[untitaker]

I am interested in working on this.

if we wanted to remove them all together we would need to do a check here to change the string getting passed into format.

I suppose for this to happen the formatting of both error messages would have to be the same. Which version is preferred, with or without backticks around the types?

[anuragsoni]

Is anyone working on this? This behavior still happens with the 1.0 stable version.

[panyam]

hey guys is anybody working on this? Id like to give this a go. First time contributing to rust so wanted something simple to start off with.

[alexispurslane]

@panyam Go ahead! I don't think anybody has though about this in a while, although it might already be fixed, so you might need to make sure.

[alexispurslane]

(I did mean to work on this, but it seems it slipped my mind)

[alexispurslane]

@panyam Welcome to Rust, by the way! 🎊

[panyam]

@ChristopherDumas - thanks for that mate... il give it a go.

[KalitaAlexey]

@panyam I want to fix that. Do you mind?

[KalitaAlexey]

I have the solution. Who can mentor me. I have some questions.

[jonas-schievink]

This is fixed, right?

[KalitaAlexey]

Yes.

[brson]

Thanks @KalitaAlexey <3