Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guide: use https for installing Rust #16504

Closed
vks opened this issue Aug 14, 2014 · 3 comments
Closed

Guide: use https for installing Rust #16504

vks opened this issue Aug 14, 2014 · 3 comments
Labels
A-security Area: Security (example: address space layout randomization).

Comments

@vks
Copy link
Contributor

vks commented Aug 14, 2014

Now that #16123 has been implemented, the guide can be updated to use

$ curl -s https://static.rust-lang.org/rustup.sh | sudo sh

instead of

$ curl -s http://www.rust-lang.org/rustup.sh | sudo sh

This provides more security, although man-in-the-middle attacks are still possible as long as the guide is served over http. To be able to fix this, Github needs to implement https for user pages first: isaacs/github#156
@steveklabnik
Copy link
Member

Sure. I'd love a PR that took care of this.

@vks
Copy link
Contributor Author

vks commented Aug 14, 2014

I just realized that this is already fixed upstream, but the website is apparently not yet updated.
I'll close the issue once the change is online.

@DomT4 DomT4 mentioned this issue Aug 14, 2014
Closed
mistydemeo pushed a commit to Homebrew/legacy-homebrew that referenced this issue Aug 15, 2014
@DomT4 @mistydemeo
Rust: Adds https
3b6431a 
Rust has adopted SSL for their download links, so Homebrew can make the switch over now. See [this](rust-lang/rust#16504) Rust Issue for further information.

Closes #31607.

Signed-off-by: Misty De Meo <[email protected]>
@thestinger
Copy link
Contributor

This is fixed: http://doc.rust-lang.org/guide.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-security Area: Security (example: address space layout randomization).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @vks @thestinger