Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement flexible target specs #16093

Closed
brson opened this issue Jul 30, 2014 · 2 comments
Closed

Implement flexible target specs #16093

brson opened this issue Jul 30, 2014 · 2 comments
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.

Comments

@brson
Copy link
Contributor

brson commented Jul 30, 2014

rust-lang/rfcs#131
@brson brson mentioned this issue Jul 30, 2014
Merged
@brson
Copy link
Contributor Author

brson commented Jul 30, 2014

@cmr @mneumann just ported to DragonFly and had some final suggestions in the RFC thread

@bharrisau
Copy link
Contributor

Something to plan for, but not implement this pass, is creating a #[cfg(target_libc = "")]. liblibc uses the target_os to work out which libc to use. Linux is glibc, Windows is msvcrt, android is Bionic, Mac/BSD is BSD libc, many other platforms are moving to newlib. Changing liblibc to be thinking about the libc instead of the OS might/should make porting easier (as you'd probably be using an existing libc).

@emberian emberian mentioned this issue Aug 1, 2014
Merged
emberian added a commit that referenced this issue Aug 24, 2014
@emberian
Implement flexible target specification
a3c8e5e 
Removes all target-specific knowledge from rustc. Some targets have changed
during this, but none of these should be very visible outside of
cross-compilation. The changes make our targets more consistent.

iX86-unknown-linux-gnu is now only available as i686-unknown-linux-gnu. We
used to accept any value of X greater than 1. i686 was released in 1995, and
should encompass the bare nimimum of what Rust supports on x86 CPUs.

The only two windows targets are now i686-pc-windows-gnu and
x86_64-pc-windows-gnu.

The iOS target has been renamed from arm-apple-ios to arm-apple-darwin.

A complete list of the targets we accept now:

arm-apple-darwin
arm-linux-androideabi
arm-unknown-linux-gnueabi
arm-unknown-linux-gnueabihf

i686-apple-darwin
i686-pc-windows-gnu
i686-unknown-freebsd
i686-unknown-linux-gnu

mips-unknown-linux-gnu
mipsel-unknown-linux-gnu

x86_64-apple-darwin
x86_64-unknown-freebsd
x86_64-unknown-linux-gnu
x86_64-pc-windows-gnu

Closes #16093

[breaking-change]

Conflicts:
	src/librustc/back/link.rs
	src/librustc/middle/trans/cabi_x86.rs
	src/librustc_back/archive.rs
eddyb pushed a commit to eddyb/rust that referenced this issue Sep 20, 2014
@emberian @eddyb
Implement flexible target specification
cc34113 
Removes all target-specific knowledge from rustc. Some targets have changed
during this, but none of these should be very visible outside of
cross-compilation. The changes make our targets more consistent.

iX86-unknown-linux-gnu is now only available as i686-unknown-linux-gnu. We
used to accept any value of X greater than 1. i686 was released in 1995, and
should encompass the bare minimum of what Rust supports on x86 CPUs.

The only two windows targets are now i686-pc-windows-gnu and
x86_64-pc-windows-gnu.

The iOS target has been renamed from arm-apple-ios to arm-apple-darwin.

A complete list of the targets we accept now:

arm-apple-darwin
arm-linux-androideabi
arm-unknown-linux-gnueabi
arm-unknown-linux-gnueabihf

i686-apple-darwin
i686-pc-windows-gnu
i686-unknown-freebsd
i686-unknown-linux-gnu

mips-unknown-linux-gnu
mipsel-unknown-linux-gnu

x86_64-apple-darwin
x86_64-unknown-freebsd
x86_64-unknown-linux-gnu
x86_64-pc-windows-gnu

Closes rust-lang#16093

[breaking-change]
vadimcn pushed a commit to vadimcn/rust that referenced this issue Nov 1, 2014
@emberian @vadimcn
Implement flexible target specification
20ad289 
Removes all target-specific knowledge from rustc. Some targets have changed
during this, but none of these should be very visible outside of
cross-compilation. The changes make our targets more consistent.

iX86-unknown-linux-gnu is now only available as i686-unknown-linux-gnu. We
used to accept any value of X greater than 1. i686 was released in 1995, and
should encompass the bare minimum of what Rust supports on x86 CPUs.

The only two windows targets are now i686-pc-windows-gnu and
x86_64-pc-windows-gnu.

The iOS target has been renamed from arm-apple-ios to arm-apple-darwin.

A complete list of the targets we accept now:

arm-apple-darwin
arm-linux-androideabi
arm-unknown-linux-gnueabi
arm-unknown-linux-gnueabihf

i686-apple-darwin
i686-pc-windows-gnu
i686-unknown-freebsd
i686-unknown-linux-gnu

mips-unknown-linux-gnu
mipsel-unknown-linux-gnu

x86_64-apple-darwin
x86_64-unknown-freebsd
x86_64-unknown-linux-gnu
x86_64-pc-windows-gnu

Closes rust-lang#16093

[breaking-change]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bharrisau @brson