Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model lexer doesn't handle CRLF correctly #15882

Closed
emberian opened this issue Jul 21, 2014 · 1 comment · Fixed by #24620
Closed

Model lexer doesn't handle CRLF correctly #15882

emberian opened this issue Jul 21, 2014 · 1 comment · Fixed by #24620
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@emberian
Copy link
Member

Tracking issue for the lexer test failing test/run-pass/lexer-crlf-line-endings-string-literal-doc-comment.rs
@emberian emberian mentioned this issue Jul 21, 2014
Closed
7 tasks
@pczarn
Copy link
Contributor

pczarn commented Jan 18, 2015

Regular comments can contain anything before LF, including CR. Doc comments don't accept CR. Seems intentional.

I wrote a fix.

@steveklabnik steveklabnik added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jan 23, 2015
@pczarn pczarn mentioned this issue Apr 20, 2015
Merged
bors added a commit that referenced this issue Apr 21, 2015
@bors
Auto merge of #24620 - pczarn:model-lexer-issues, r=cmr
7397bdc 
Fixes #15679
Fixes #15878
Fixes #15882
Closes #15883
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 16, 2023
@bors
Auto merge of rust-lang#15882 - Veykril:fix-config-keys, r=Veykril
4fc208e 
minor: Fix import preference config keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Model lexer: Fix remaining issues pczarn/rust
3 participants
@steveklabnik @emberian @pczarn