Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hygiene for self will be tricky #15383

Closed
jbclements opened this issue Jul 3, 2014 · 2 comments
Closed

hygiene for self will be tricky #15383

jbclements opened this issue Jul 3, 2014 · 2 comments

Comments

@jbclements
Copy link
Contributor

Hygiene for self will be a bit tricky. In particular, the AST doesn't actually contain a binding identifier for self, which means that the resolver doesn't actually have identifiers that can be compared hygienically.

I believe that getting hygiene to work correctly for self will involve equipping the Method node with a self identifier, and then performing a hygienic comparison in resolution.
@jbclements
Copy link
Contributor Author

Wow, I'm totally wrong! It works out of the box! Magnificent.

@jbclements
Copy link
Contributor Author

ooh... spoke too soon. The FnDecl does contain an explicit arg for self, but renaming causes something to break.

bors added a commit to rust-lang-ci/rust that referenced this issue Aug 21, 2023
@bors
Auto merge of rust-lang#15383 - max-heller:issue-12568, r=Veykril
f73cd39 
Suggest type completions for type arguments and constant completions for constant arguments

When determining completions for generic arguments, suggest only types or only constants if the corresponding generic parameter is a type parameter or constant parameter.

Closes rust-lang#12568
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbclements