Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate crate_id's #14470

Closed
brson opened this issue May 27, 2014 · 1 comment · Fixed by #15319
Closed

Eliminate crate_id's #14470

brson opened this issue May 27, 2014 · 1 comment · Fixed by #15319
Assignees
@alexcrichton
Milestone
1.0

Comments

@brson
Copy link
Contributor

brson commented May 27, 2014

cc #14468

Completely remove the concept of crate_ids. In a cargo world, nothing but the crate name matters to rustc. It's not clear yet whether crate_id needs to be replaced with crate_name, or whether rustc can get by without any of this metadata.

Nominating.
@brson brson mentioned this issue May 27, 2014
Closed
@klutzy klutzy mentioned this issue May 28, 2014
Closed
@brson brson added this to the 1.0 milestone May 29, 2014
@brson
Copy link
Contributor Author

brson commented May 29, 2014

1.0 P-backcompat-lang

@alexcrichton alexcrichton mentioned this issue Jun 6, 2014
Merged
@alexcrichton alexcrichton mentioned this issue Jul 2, 2014
Merged
bors added a commit that referenced this issue Jul 5, 2014
@bors
auto merge of #15319 : alexcrichton/rust/no-crate-id, r=brson
c3ef04b 
This is an implementation of [RFC 35](https://github.com/rust-lang/rfcs/blob/master/active/0035-remove-crate-id.md).

The summary for this PR is the same as that of the RFC, with one addendum:


* Removes the `#[crate_id]` attribute and knowledge of versions from rustc.
* Added a `#[crate_name]` attribute similar to the old `#[crate_id]` attribute
* Output filenames no longer have versions or hashes
* Symbols no longer have versions (they still have hashes)
* A new flag, `--extern`, is used to override searching for external crates
* A new flag, `-C metadata=foo`, used when hashing symbols
* [added] An old flag, `--crate-name`, was re purposed to specify the crate name from the command line.

I tried to maintain backwards compatibility wherever possible (with warnings being printed). If I missed anywhere, however, please let me know!

[breaking-change]

Closes #14468
Closes #14469
Closes #14470
Closes #14471
bors added a commit to rust-lang-ci/rust that referenced this issue Jun 5, 2023
@bors
Auto merge of rust-lang#14511 - HKalbasi:dev, r=Veykril
e739c99 
Always reborrow mutable reference receiver in methods

Dependency of rust-lang#14470
bors added a commit to rust-lang-ci/rust that referenced this issue Jun 5, 2023
@bors
Auto merge of rust-lang#14521 - HKalbasi:dev, r=Veykril
937ef97 
Add bounds for fields in derive macro

Dependency of rust-lang#14470
bors added a commit to rust-lang-ci/rust that referenced this issue Jun 5, 2023
@bors
Auto merge of rust-lang#14470 - HKalbasi:mir, r=HKalbasi
44cf8ef 
Compute closure captures

This PR:
* Computes closure captures and the trait it implements (Fn, FnMut or FnOnce)
* Computes data layout of closures
* Adds support for closure MIR lowering
* Changes the closure type display from `|arg1: ty1, arg2: ty| -> ret` to `impl FnX(arg1: ty1, arg2: ty2) -> ret`

fix rust-lang#12297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Remove #[crate_id] alexcrichton/rust
2 participants
@alexcrichton @brson