-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a pass to mark doc attributes as used #14408
Comments
Triage: no change that I'm aware of. |
Triage: same as last year |
Triage: There's a new lint |
@Havvy When/where was this lint added? I'm not familiar with it. |
Added in #43009, where this case is specifically tested. |
Closing as per the above, looks like this was implemented in the unused_doc_comments lint. |
internal: Only intern blocks that declare items We only used `BlockId` for the block defmap, so this is wasted memory. Lowering for non item declaring blocks is also cheaper now as we no longer have to fully lower a block that defines not items.
The unused-attribute lint currently globally whitelists all doc attributes as used, even if they're placed in contexts that rustdoc would never look at (e.g. match arms). There should be a separate pass over the AST that marks the attributes in the correct contexts.
The text was updated successfully, but these errors were encountered: