Editor highlighting and syntax should also be packaged in the installer packages #13334
Labels
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
Comments
|
/cc @brson ? |
|
This may be trickier now that the configs are in separate repos (cc #18274 (comment)). |
|
Triage: no change. |
steveklabnik
added
the
C-enhancement
|
This is a pretty old bug at this point, but all our editor integration has its own packaging/distribution mechanisms, so I'm going to close this. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Oct 18, 2024
Add manual_ignore_cast_cmp lint
```rust
// bad
fn compare(a: &str, b: &str) -> bool {
a.to_ascii_lowercase() == b.to_ascii_lowercase()
|| a.to_ascii_lowercase() == "abc"
}
// good
fn compare(a: &str, b: &str) -> bool {
a.eq_ignore_ascii_case(b)
|| a.eq_ignore_ascii_case("abc")
}
```
- [x] Followed [lint naming conventions][lint_naming]
- [x] Added passing UI tests (including committed `.stderr` file)
- [x] `cargo test` passes locally
- [x] Executed `cargo dev update_lints`
- [x] Added lint documentation
- [x] Run `cargo dev fmt`
changelog: New lint: [`manual_ignore_case_cmp`] `perf`
[rust-lang#13334](rust-lang/rust-clippy#13334)
Closes rust-lang#13204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
src/etc/{emacs, gedit, kate, vim, zsh}folders should also be packaged. This would make it easier for package maintainers to include them.The text was updated successfully, but these errors were encountered: