-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: change in paths/CWD for rustdoc tests #132203
Comments
This seems to have changed via #130582 (cc @notriddle). Reproduction:
|
…k, r=GuillaumeGomez rustdoc: make doctest span tweak a 2024 edition change Fixes rust-lang#132203 This is a compatibility hack, because I think the new behavior is better. When an A `include_str!` B, and B `include_str!` C, the path to C should be resolved relative to B, not A. That's how `include!` itself works, so that's how `include_str!` with should work.
Ok, removing the prioritization label as it is in @rustbot label -I-prioritize |
…ack, r=GuillaumeGomez rustdoc: make doctest span tweak a 2024 edition change Fixes rust-lang#132203 This is a compatibility hack, because I think the new behavior is better. When an A `include_str!` B, and B `include_str!` C, the path to C should be resolved relative to B, not A. That's how `include!` itself works, so that's how `include_str!` with should work.
…ack, r=GuillaumeGomez rustdoc: make doctest span tweak a 2024 edition change Fixes rust-lang#132203 This is a compatibility hack, because I think the new behavior is better. When an A `include_str!` B, and B `include_str!` C, the path to C should be resolved relative to B, not A. That's how `include!` itself works, so that's how `include_str!` with should work.
Rollup merge of rust-lang#132210 - notriddle:notriddle/doctest-span-hack, r=GuillaumeGomez rustdoc: make doctest span tweak a 2024 edition change Fixes rust-lang#132203 This is a compatibility hack, because I think the new behavior is better. When an A `include_str!` B, and B `include_str!` C, the path to C should be resolved relative to B, not A. That's how `include!` itself works, so that's how `include_str!` with should work.
Should this have
regression-from-stable-to-stable
|
The text was updated successfully, but these errors were encountered: