Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download_ci_llvm test failure when updating LLVM #131303

Closed
nikic opened this issue Oct 5, 2024 · 3 comments · Fixed by #131305
Closed

download_ci_llvm test failure when updating LLVM #131303

nikic opened this issue Oct 5, 2024 · 3 comments · Fixed by #131305
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@nikic
Copy link
Contributor

nikic commented Oct 5, 2024

From #131293 (comment):

2024-10-05T14:07:30.4627940Z failures:
2024-10-05T14:07:30.4628774Z 
2024-10-05T14:07:30.4629533Z ---- core::config::tests::download_ci_llvm stdout ----
2024-10-05T14:07:30.4630298Z thread 'core::config::tests::download_ci_llvm' panicked at src/core/config/tests.rs:33:5:
2024-10-05T14:07:30.4630892Z assertion `left == right` failed
2024-10-05T14:07:30.4631199Z   left: true
2024-10-05T14:07:30.4632659Z  right: false
2024-10-05T14:07:30.4632897Z 
2024-10-05T14:07:30.4632913Z 
2024-10-05T14:07:30.4633046Z failures:
2024-10-05T14:07:30.4633383Z     core::config::tests::download_ci_llvm

Variants of this issue appear with surprising regularity, this is probably already the tenth time that bootstrap tests fail if and only if the LLVM submodule is updated.

We probably need a CI job that adds a dummy commit to the submodule and verifies that bootstrap tests still pass after that.
@nikic nikic added C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 5, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 5, 2024
@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 5, 2024
@onur-ozkan
Copy link
Member

Any idea if that happened before #130383?

@onur-ozkan onur-ozkan mentioned this issue Oct 5, 2024
Merged
@DianQK
Copy link
Member

DianQK commented Oct 6, 2024

Any idea if that happened before #130383?

This happened once before #130383: #130641 (comment).

@DianQK DianQK mentioned this issue Oct 10, 2024
Merged
@bors bors closed this as completed in c4e7425 Oct 11, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 11, 2024
@rust-timer
Unrolled build for rust-lang#131305
f7b91a1 
Rollup merge of rust-lang#131305 - onur-ozkan:131303, r=Kobzol

make `llvm::is_ci_llvm_modified` logic more precise

Fixes rust-lang#131303.
@nikic
Copy link
Contributor Author

nikic commented Oct 11, 2024

I've filed #131545 for the "test this in CI" part of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make llvm::is_ci_llvm_modified logic more precise onur-ozkan/rust
4 participants
@nikic @DianQK @onur-ozkan @rustbot