Regression in rustdoc output #131223
Labels
A-rustdoc-ui
Area: Rustdoc UI (generated HTML)
C-discussion
Category: Discussion or questions that doesn't represent real issues.
T-rustdoc-frontend
Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Comments
rustbot
added
the
needs-triage
jieyouxu
added
A-rustdoc-ui
I think this is a consequence of #130933 which was intended to address #130622. GG is adding a UI regression test for the spacing in #131209 for #130622. cc @GuillaumeGomez |
|
It's indeed something that we changed on purpose. |
jieyouxu
added
C-discussion
|
Little modification: the changes are improving the situation but introducing some new other issues. Talking about it currently to figure out what's the best solution. |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Oct 4, 2024
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Oct 4, 2024
|
I opened #131257. Please don't hesitate to take a look. Hopefully I was able to improve the current situation without going back to the original issue. |
Certainly seems better than before! |
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this issue
Oct 4, 2024
…=notriddle [rustdoc] Fix list margins Fixes rust-lang#131106. Fixes rust-lang#131223. Follow-up of rust-lang#130933. This PR changes the display as follow: the margin between list items is reduced by half to ensure that they visually still seem part of the same list, while also being bigger than previously which improves display for list items with more than one paragragh. Paragraphs also get they bottom margin reduced to a little bit less than the list items bottom margin for two reasons: 1. The list items keep having the biggest bottom margin which makes it better for coherency. 2. The paragraphs are still visually separated but they don't "overcome" the list. | before | after | |-|-| |  |  | Can be tested [here](https://rustdoc.crud.net/imperio/fix-list-margins/doc/test_docs/long_list/index.html). r? `@notriddle`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Oct 5, 2024
Rollup merge of rust-lang#131257 - GuillaumeGomez:fix-list-margins, r=notriddle [rustdoc] Fix list margins Fixes rust-lang#131106. Fixes rust-lang#131223. Follow-up of rust-lang#130933. This PR changes the display as follow: the margin between list items is reduced by half to ensure that they visually still seem part of the same list, while also being bigger than previously which improves display for list items with more than one paragragh. Paragraphs also get they bottom margin reduced to a little bit less than the list items bottom margin for two reasons: 1. The list items keep having the biggest bottom margin which makes it better for coherency. 2. The paragraphs are still visually separated but they don't "overcome" the list. | before | after | |-|-| |  |  | Can be tested [here](https://rustdoc.crud.net/imperio/fix-list-margins/doc/test_docs/long_list/index.html). r? ``@notriddle``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I tried this code: https://github.com/google/zerocopy/tree/52e91319e144bf91a86b688b770d5d4e3735d9d4
I ran the following commands:
On 2024-10-01, this renders like this
On 2024-10-02, this renders like this
Note that the bullet points are spaced farther apart. I'm assuming this is a regression?
The text was updated successfully, but these errors were encountered: