Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgreen's stack_bounds implementation includes the guard page #12897

Closed
jdm opened this issue Mar 14, 2014 · 3 comments
Closed

libgreen's stack_bounds implementation includes the guard page #12897

jdm opened this issue Mar 14, 2014 · 3 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows

Comments

@jdm
Copy link
Contributor

jdm commented Mar 14, 2014

rust-mozjs uses the stack bounds to inform SpiderMonkey's conservative stack scanner, but it started segfaulting on the guard page after the most recent upgrade. Does it really make sense to include this page, or should we add some kind of usable_stack_bounds method?
@jdm jdm added the A-runtime label Mar 14, 2014
@thestinger
Copy link
Contributor

It needs a guard page, because it's the only thing stopping a stack overflow in C code called by Rust. The guard page will allow removing __morestack and using a more efficient scheme like the GCC -fcheck-stack instead.

@metajack
Copy link
Contributor

Yes, obviously the guard page is needed. The question is should we report the guard page in the stack bounds. I think not, since obviously you aren't supposed to use that memory.

@thestinger
Copy link
Contributor

Yeah, that makes sense.

@alexcrichton alexcrichton mentioned this issue Mar 15, 2014
Closed
bors added a commit that referenced this issue Mar 15, 2014
@bors
auto merge of #12908 : alexcrichton/rust/issue-12897, r=thestinger
352c5e7 
This is mostly just an implementation detail, and anyone worried about the stack
bounds doesn't need to be bothered with the red zone because it's not usable
anyway.

Closes #12897
arcnmx pushed a commit to arcnmx/rust that referenced this issue Dec 17, 2022
@bors
Auto merge of rust-lang#13728 - detrumi:chalk-update, r=lnicola
f9bd487 
Update to Chalk 88

This Chalk release introduces fuel for the recursive solver ([chalk#774](rust-lang/chalk#774)).
I'm not sure how often it calls `should_continue` compared to the other solver, so we might want to increase `CHALK_SOLVER_FUEL`, the current default value of 100 might be too low.

This should fix a lot of hangs and crashes, for example this solves the hang in rust-lang#12897.
flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 13, 2024
@bors
Auto merge of rust-lang#12897 - lochetti:manual_unwrap_or_default_res…
d9ae936 
…ult, r=dswij

Lint `manual_unwrap_or_default` for Result as well

This PR is modifying the  `manual_unwrap_or_default` to be applied/linted for `Result`s as well. It is part of the fixes desired by rust-lang/rust-clippy#12618

changelog:[`manual_unwrap_or_default`]: Lint for Result types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

green: Don't return the red zone in stack_bounds() alexcrichton/rust
3 participants
@jdm @metajack @thestinger