tests/run-make/print-target-list --print=sysroot check fails for experimental llvm targets
#127895
Labels
A-run-make
Area: port run-make Makefiles to rmake.rs
A-testsuite
Area: The testsuite used to check the correctness of rustc
C-bug
Category: This is a bug.
O-AVR
Target: AVR processors (ATtiny, ATmega, etc.)
O-csky
Target: glaCSKY above covers over me~
O-motorola68k
Target: Rust from the parallel universe where the Amiga won.
O-xtensa
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
jieyouxu
added
T-compiler
rustbot
added
the
needs-triage
jieyouxu
added
A-testsuite
|
Is there any COMPILETEST_NEEDS_ALL_LLVM_COMPONENTS set by us for this jobs?. It seems like the same issue. I will check it later. |
|
Well, I'm not familiar with rmake. However, the right logic should be like: If
|
|
Ah thank you, that sounds about right. |
jieyouxu
changed the title
tests/run-make/print-target-list fails for csky-unknown-linux-gnuabiv2tests/run-make/print-target-list fails for experimental llvm targets
jieyouxu
added
O-AVR
jieyouxu
changed the title
tests/run-make/print-target-list fails for experimental llvm targetstests/run-make/print-target-list --print=sysroot check fails for experimental llvm targets
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Aug 31, 2024
…Mark-Simulacrum Add missing `needs-llvm-components` directives for run-make tests that need target-specific codegen Without suitable `needs-llvm-components` directives, some run-make tests exercising target-specific codegen can fail if the LLVM used is built without the necessary components. Currently, the list is: ``` tests\run-make\print-target-list tests\run-make\print-to-output tests\run-make\print-cfg tests\run-make\target-without-atomic-cas ``` This PR also skips tidy checks for revisions and `needs-llvm-components` for run-make tests since revisions are not supported. Fixes rust-lang#129390. Fixes rust-lang#127895. cc `@petrochenkov` who noticed this, thanks! Would be great if you could confirm that this fixes the test errors for you locally.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Aug 31, 2024
Rollup merge of rust-lang#129605 - jieyouxu:needs-llvm-components, r=Mark-Simulacrum Add missing `needs-llvm-components` directives for run-make tests that need target-specific codegen Without suitable `needs-llvm-components` directives, some run-make tests exercising target-specific codegen can fail if the LLVM used is built without the necessary components. Currently, the list is: ``` tests\run-make\print-target-list tests\run-make\print-to-output tests\run-make\print-cfg tests\run-make\target-without-atomic-cas ``` This PR also skips tidy checks for revisions and `needs-llvm-components` for run-make tests since revisions are not supported. Fixes rust-lang#129390. Fixes rust-lang#127895. cc ``@petrochenkov`` who noticed this, thanks! Would be great if you could confirm that this fixes the test errors for you locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #127877 @Rejyr noticed
tests/run-make/print-target-listwas failing forcsky-unknown-linux-gnuabiv2(and other experimental llvm components) on thex86_64-gnu-llvm-17CI builder with#125702 (specifically #125702 (comment)) it was already noticed that
tests/run-make/print-target-listseemed to fail forcsky-unknown-linux-gnuabiv2.Is this expected? Or what is the expected test behavior when
is ran (on the
x86_64-gnu-llvm-17CI builder)?Or is it expected that we should skip trying to run this check for the
csky-unknown-linux-gnuabiv2and other experimental llvm component targets?Update: this is also true for experimental llvm components
avr,m68k,cskyandxtensa, not too sure what the correct behavior is. Currently these targets are skipped byprint-target-list's--print=sysrootcheck.The text was updated successfully, but these errors were encountered: