Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICE: lookup_item: id not found: 473214 #12696

Closed
zmike opened this issue Mar 5, 2014 · 1 comment
Closed

ICE: lookup_item: id not found: 473214 #12696

zmike opened this issue Mar 5, 2014 · 1 comment

Comments

@zmike
Copy link

zmike commented Mar 5, 2014

Caused by this block of code in my Servo branch, not sure exactly what...
https://github.com/zmike/servo/blob/master/src/components/embedding/core.rs#L86

I'm on x86_64 linux, this is the backtrace from rust_fail:
https://gist.github.com/zmike/9358460
@zmike
Copy link
Author

zmike commented Mar 5, 2014

Nevermind, the @larsbergstrom magic fixed it.

@zmike zmike closed this as completed Mar 5, 2014
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
@bors
Auto merge of rust-lang#12696 - hi-rustin:rustin-patch-fix, r=Veykril
fc47ce5 
Add str_ref_to_string fix

close rust-lang/rust-analyzer#11383
When type mismatch is `&str` -> `String` try to fix it.
flip1995 pushed a commit to flip1995/rust that referenced this issue May 2, 2024
@bors
Auto merge of rust-lang#12696 - smoelius:fix-is_test_module_or_functi…
c642d0c 
…on, r=Alexendoo

Fix `is_test_module_or_function`

The rustdoc comment for `is_test_module_or_function` states: https://github.com/rust-lang/rust-clippy/blob/2795a6018944a5918b7d276267165484f5d62d6a/clippy_utils/src/lib.rs#L2561-L2566

Given `item`, the function calls `is_in_test_function` with `item.hir_id()`. However, `is_in_test_function` considers only `item`'s parents, not `item` itself. This PR fixes the problem.

The `test_with_disallowed_name` test fails without the fix, but passes once applied.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zmike