Adjust the rustdoc highlighting colour scheme

[huonw]

It's currently very bright and distracting (IMO).

(Sorry @alexcrichton :( )

Current scheme, for future triage/comparison purposes:

[alexcrichton]

I think I should reconsider my career in graphic design.

[adrientetar]

I'm looking at this.

[huonw]

(The relevant file is src/librustdoc/html/static/main.css, if you're lost. :) )

[adrientetar]

BTW I was wondering, why not just use <ol><li> for src line numbering?
Probably more optimized/idiomatic in the browser.

[adrientetar]

Also, it's pretty much impossible to have consistency between rustdoc and the old codemirror (tutorial) since both parsers behave very differently.
@alexcrichton, would it be possible to pass the standalone documentation through rustdoc?

[huonw]

BTW I was wondering, why not just use

1. for src line numbering?
   Probably more optimized/idiomatic in the browser.

Doesn't this mean every line is a new <pre> tag? Also, it possibly screws with copy-paste and making the formatting consistent.

This bug is specifically about the colour scheme of rustdoc since it's so wild.

Also, #11392 about using rustdoc for everything.

[eddyb]

My preference for the highlighting scheme is bold for keywords, green for macros, red for strings (the current color is fine), gray for comments (would be nice if code within comments were highlighted).
I'd also like to hear more suggestions before we change it.

[huonw]

Something I hacked up a few days ago:

(The macro colour wasn't "optimised" at all.)

[adrientetar]

Doesn't this mean every line is a new <pre> tag?

No, it would look like this:

<pre class="code">
  <ol>
    <li class="L1"></li>
    <li class="L2"></li>
    <li class="L3"></li>
    ...
  </ol>
</pre>

I think it would be better to use that since that's the browser native numberings.

Also, it possibly screws with copy-paste and making the formatting consistent.

No it doesn't. The identifier of a list aren't inlined with the content. Here is an example.

[huonw]

Oh, awesome. It does seem like a good idea, if you can get that to work.

[adrientetar]

Another note: current rustdoc parsing could be improved, i.e. the "ident" class corresponds to variable names, function names, paths, parameters... could be more split if you ask me.

[huonw]

The highlighting is performed by just by the token types the lexer (with a little bit of extra logic for attributes, macros and $ non-terminals in macros) and so does not have that information.