Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: opaque types got hidden types registered from within subtype predicate #125192

Closed
BoxyUwU opened this issue May 17, 2024 · 3 comments · Fixed by #125489
Closed

regression: opaque types got hidden types registered from within subtype predicate #125192

BoxyUwU opened this issue May 17, 2024 · 3 comments · Fixed by #125489
Assignees
@oli-obk
Labels
I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ P-critical Critical priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
1.79.0

Comments

@BoxyUwU
Copy link
Member

BoxyUwU commented May 17, 2024 

[INFO] [stderr] thread 'rustc' panicked at compiler/rustc_infer/src/infer/mod.rs:956:17:
[INFO] [stdout] error: internal compiler error: compiler/rustc_infer/src/infer/mod.rs:956:17: opaque types got hidden types registered from within subtype predicate: itertools::Either<Alias(Opaque, AliasTy { args: ['?52, '?14], def_id: DefId(0:28837 ~ smoldot[145d]::header::babe::{impl#3}::scale_encoding::{opaque#0}::{opaque#0}) }), [u8; 4_usize]> vs itertools::Either<Alias(Opaque, AliasTy { args: ['?39, '?14], def_id: DefId(0:28837 ~ smoldot[145d]::header::babe::{impl#3}::scale_encoding::{opaque#0}::{opaque#0}) }), [u8; 4_usize]>
[INFO] [stdout]   --> src/header/babe.rs:83:17
[INFO] [stdout]    |
[INFO] [stdout] 83 | /                 iter::once(either::Right(either::Left([1]))).chain(
[INFO] [stdout] 84 | |                     digest
[INFO] [stdout] 85 | |                         .scale_encoding()
[INFO] [stdout] 86 | |                         .map(either::Right)
[INFO] [stdout] 87 | |                         .map(either::Right),
[INFO] [stdout] 88 | |                 ),
[INFO] [stdout]    | |_________________^

probably #123979 cc @oli-obk @compiler-errors
@BoxyUwU BoxyUwU added I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels May 17, 2024
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels May 17, 2024
@BoxyUwU BoxyUwU mentioned this issue May 17, 2024
Closed
@BoxyUwU BoxyUwU added this to the 1.79.0 milestone May 17, 2024
@compiler-errors
Copy link
Member

Yeah Matthias also found #123979. Think it hasn't been fixed b/c oli is on holiday -- I assume he will investigate when he's back next week.

@lqd
Copy link
Member

lqd commented May 17, 2024

MCVE in #124891

@saethlin saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 18, 2024
@apiraino
Copy link
Contributor

WG-prioritization assigning priority (Zulip discussion).

I'll mark this as P-critical because it seems an unintended breaking change and therefore should probably be fixed before entering into stable.

@rustbot label -I-prioritize +P-critical

@rustbot rustbot added P-critical Critical priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels May 21, 2024
@oli-obk oli-obk self-assigned this May 23, 2024
This was referenced May 23, 2024
Merged
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue May 24, 2024
@matthiaskrgr
Rollup merge of rust-lang#125489 - oli-obk:revert_stuff_2, r=compiler…
0ba9fc2 
…-errors

Revert problematic opaque type change

fixes rust-lang#124891
fixes rust-lang#125192

reverts rust-lang#123979
@bors bors closed this as completed in 1a165ec May 24, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue May 24, 2024
@rust-timer
Unrolled build for rust-lang#125489
09e9d49 
Rollup merge of rust-lang#125489 - oli-obk:revert_stuff_2, r=compiler-errors

Revert problematic opaque type change

fixes rust-lang#124891
fixes rust-lang#125192

reverts rust-lang#123979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oli-obk oli-obk

Labels
I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ P-critical Critical priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging a pull request may close this issue.

Revert problematic opaque type change oli-obk/rust
7 participants
@lqd @oli-obk @compiler-errors @apiraino @saethlin @BoxyUwU @rustbot