-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad diagnostic in breaking labeled block? #123261
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
A-suggestion-diagnostics
Area: Suggestions generated by the compiler applied by `cargo fix`
D-invalid-suggestion
Diagnostics: A structured suggestion resulting in incorrect code.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
chacha21
added
A-diagnostics
Area: Messages for errors, warnings, and lints
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Mar 31, 2024
fmease
added
A-suggestion-diagnostics
Area: Suggestions generated by the compiler applied by `cargo fix`
D-invalid-suggestion
Diagnostics: A structured suggestion resulting in incorrect code.
labels
Mar 31, 2024
@rustbot claim |
surechen
added a commit
to surechen/rust
that referenced
this issue
Apr 8, 2024
…k, or we wiil get another err: block label not supported here. fixes rust-lang#123261
surechen
added a commit
to surechen/rust
that referenced
this issue
Apr 9, 2024
…k, or we wiil get another err: block label not supported here. fixes rust-lang#123261
surechen
added a commit
to surechen/rust
that referenced
this issue
Apr 11, 2024
…k, or we wiil get another err: block label not supported here. fixes rust-lang#123261
surechen
added a commit
to surechen/rust
that referenced
this issue
Apr 11, 2024
…k, or we wiil get another err: block label not supported here. fixes rust-lang#123261
surechen
added a commit
to surechen/rust
that referenced
this issue
May 21, 2024
…r we wiil get another err: block label not supported here. fixes rust-lang#123261
surechen
added a commit
to surechen/rust
that referenced
this issue
May 21, 2024
…r we wiil get another err: block label not supported here. fixes rust-lang#123261
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
May 23, 2024
Fix OutsideLoop's error suggestion: adding label `'block` for `if` block. For OutsideLoop we should not suggest add `'block` label in `if` block, or we wiil get another err: block label not supported here. fixes rust-lang#123261
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
May 23, 2024
Rollup merge of rust-lang#123623 - surechen:fix_123261, r=estebank Fix OutsideLoop's error suggestion: adding label `'block` for `if` block. For OutsideLoop we should not suggest add `'block` label in `if` block, or we wiil get another err: block label not supported here. fixes rust-lang#123261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
A-suggestion-diagnostics
Area: Suggestions generated by the compiler applied by `cargo fix`
D-invalid-suggestion
Diagnostics: A structured suggestion resulting in incorrect code.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Code
Current output
Desired output
Rationale and extra context
The problem in the diagnostic is to mention the hint:
Which is wrong because a label cannot be set here after an
if
clauseOther cases
No response
Rust Version
Anything else?
https://users.rust-lang.org/t/bad-diagnostic-in-breaking-labeled-block/109124
The text was updated successfully, but these errors were encountered: