Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"no warnings or errors encountered even though delayed_good_path_bugs issued" after panic #117381

Closed
RalfJung opened this issue Oct 30, 2023 · 0 comments · Fixed by #117397
Closed

"no warnings or errors encountered even though delayed_good_path_bugs issued" after panic #117381

RalfJung opened this issue Oct 30, 2023 · 0 comments · Fixed by #117397
Labels
C-bug Category: This is a bug. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@RalfJung
Copy link
Member

I'm getting a panic

thread 'rustc' panicked at compiler/rustc_ty_utils/src/abi.rs:360:21:
`PassMode::Direct` for aggregates only allowed on wasm and `extern "ptx-kernel"` fns
Problematic type: TyAndLayout {
    ty: ReprC1<*const i32>,
...

(that's expected, I'm working on that part of the compiler)
and after that I am getting a second error

error: internal compiler error: no warnings or errors encountered even though `delayed_good_path_bugs` issued

error: internal compiler error: trimmed_def_paths constructed but no error emitted; use `DelayDm` for lints or `with_no_trimmed_paths` for debugging

That's bad, it makes the panic message harder to find. It's also wrong, there was an error encountered, a panic even!

Cc @compiler-errors -- that's one of the trimmed-path issues I encountered recently (but might be unrelated to #117373)
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 30, 2023
@compiler-errors compiler-errors mentioned this issue Oct 30, 2023
Merged
@saethlin saethlin added I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Oct 30, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 1, 2023
@matthiaskrgr
Rollup merge of rust-lang#117397 - compiler-errors:dont-emit-good-pat…
d65fffc 
…h-on-panic, r=TaKO8Ki

Don't emit delayed good-path bugs on panic

This should fix rust-lang#117381, cc `@RalfJung`

As opposed to delayed bugs, delayed *good path* bugs really don't make sense to show on panics.
@bors bors closed this as completed in 6bbe22c Nov 1, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Nov 1, 2023
@rust-timer
Unrolled build for rust-lang#117397
4fac141 
Rollup merge of rust-lang#117397 - compiler-errors:dont-emit-good-path-on-panic, r=TaKO8Ki

Don't emit delayed good-path bugs on panic

This should fix rust-lang#117381, cc ``@RalfJung``

As opposed to delayed bugs, delayed *good path* bugs really don't make sense to show on panics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't emit delayed good-path bugs on panic compiler-errors/rust
3 participants
@RalfJung @saethlin @rustbot