Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identical test files #11496

Closed
kud1ing opened this issue Jan 12, 2014 · 3 comments · Fixed by #15106
Closed

Identical test files #11496

kud1ing opened this issue Jan 12, 2014 · 3 comments · Fixed by #15106

Comments

@kud1ing
Copy link

kud1ing commented Jan 12, 2014

The following test files are identical nowadays:

Can one of them go?
@sfackler
Copy link
Member

The last two are intentionally there.

@kud1ing
Copy link
Author

kud1ing commented Jan 12, 2014

Is this documented?

@sfackler
Copy link
Member

foo.rs and foo/mod.rs are two ways to specify the same module. Those are there to make sure that rustc complains.

@kud1ing kud1ing mentioned this issue Jun 19, 2014
Merged
Sawyer47 added a commit to Sawyer47/rust that referenced this issue Jun 23, 2014
@Sawyer47
Remove duplicated test files
37b8ce0 
Even if they used to test different things in the past, they are
now identical to other files.

Closes rust-lang#11496
@Sawyer47 Sawyer47 mentioned this issue Jun 23, 2014
Merged
bors added a commit that referenced this issue Jun 23, 2014
@bors
auto merge of #15106 : Sawyer47/rust/rm-duplicated-tests, r=alexcrichton
575710f 
Even if they used to test different things in the past, they are
now identical to other files.

Closes #11496
flip1995 pushed a commit to flip1995/rust that referenced this issue Oct 21, 2023
@bors
Auto merge of rust-lang#11496 - jonboh:prefix_postfix_struct, r=y21
fe21991 
add lint for struct field names

changelog: [`struct_field_names`]: lint structs with the same pre/postfix in all fields or with fields that are pre/postfixed with the name of the struct.

fixes rust-lang#2555

I've followed general structure and naming from the code in [enum_variants](https://github.com/rust-lang/rust-clippy/blob/b788addfcc955368b9771b77d312c248fab60253/clippy_lints/src/enum_variants.rs) lint, which implements the same logic for enum variants.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicated test files Sawyer47/rust
2 participants
@kud1ing @sfackler