Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x.py test ignores --no-fail-fast in some tool testsuites. #108261

Closed
jchecahi opened this issue Feb 20, 2023 · 2 comments · Fixed by #108264
Closed

x.py test ignores --no-fail-fast in some tool testsuites. #108261

jchecahi opened this issue Feb 20, 2023 · 2 comments · Fixed by #108264
Assignees
@jchecahi
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jchecahi
Copy link

jchecahi commented Feb 20, 2023 •
edited by rustbot
Loading

It looks like some tool testsuites (like clippy's or rustfmt's) will ignore the no fail fast option. For example running ./x.py test --no-fail-fast clippy will stop after compile-test fails, something common in big endian platforms.

If I understand correctly this seems to be because bootstrap is not passing --no-fail-fast to cargo test in every tool implementation. Currently, the flag is passed in the Step trait implementation of some tools (i.e. cargo), right after calling tool::prepare_tool_cargo(). But others like mentioned clippy or rustfmt are missing it.
@jchecahi
Copy link
Author

@rustbot claim

@jchecahi jchecahi mentioned this issue Feb 20, 2023
Merged
@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels Feb 20, 2023
@jyn514
Copy link
Member

jyn514 commented Feb 20, 2023

cc #104198

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Feb 22, 2023
@GuillaumeGomez
Rollup merge of rust-lang#108264 - jchecahi:tool-testsuite-ignores-no…
8fd47a6 
…-fail-fast, r=ozkanonur

no-fail-fast support for tool testsuites

~~This commit adds a change to pass "--no-fail-fast" flag to `cargo test` inside `tool::prepare_tool_cargo()` so there is no need to do it manually in each `Step` trait implementation in src/bootstrap/test.rs.~~

~~Also, removes the flag from test.rs where prepare_tool_cargo() is called so cargo doesn't complain because the flag has been passed twice.~~

This commit adds `--no-fail-fast` flag to each `cargo test`
command in each tool Step trait implementation (`miri`, `rustfmt` and `clippy`).

Fixes rust-lang#108261
@bors bors closed this as completed in 2f16355 Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jchecahi jchecahi

Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

no-fail-fast support for tool testsuites jchecahi/rust
2 participants
@jyn514 @jchecahi