Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement thin archive reading for ArArchiveBuilder #107407

Closed
bjorn3 opened this issue Jan 28, 2023 · 4 comments · Fixed by #128936
Closed

Implement thin archive reading for ArArchiveBuilder #107407

bjorn3 opened this issue Jan 28, 2023 · 4 comments · Fixed by #128936
Labels
A-linkage Area: linking into static, shared libraries and binaries C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@bjorn3
Copy link
Member

bjorn3 commented Jan 28, 2023

Needs to be done before #107360 can be reverted.
@bjorn3 bjorn3 added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jan 28, 2023
@ChrisDenton
Copy link
Member

Tbh, I am somewhat surprised that people are using thin archives on Windows.

@jyn514 jyn514 mentioned this issue Apr 8, 2023
Closed
This was referenced Mar 19, 2024
Merged
Closed
@bjorn3 bjorn3 changed the title Inplement thin archive reading for ArArchiveBuilder Implement thin archive reading for ArArchiveBuilder Mar 19, 2024
@bjorn3
Copy link
Member Author

bjorn3 commented Mar 19, 2024

cc #107162

@bjorn3 bjorn3 added the A-linkage Area: linking into static, shared libraries and binaries label Mar 19, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Mar 20, 2024
@GuillaumeGomez
Rollup merge of rust-lang#122723 - bjorn3:archive_writer_fixes, r=nne…
e779e97 
…thercote

Use same file permissions for ar_archive_writer as the LLVM archive writer

This is required to switch to ar_archive_writer in the future without regressions. In addition to this PR support for reading thin archives needs to be added (rust-lang#107407) to fix all known regressions.

Fixes rust-lang#107495
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Mar 20, 2024
@GuillaumeGomez
Rollup merge of rust-lang#122723 - bjorn3:archive_writer_fixes, r=nne…
04fae8c 
…thercote

Use same file permissions for ar_archive_writer as the LLVM archive writer

This is required to switch to ar_archive_writer in the future without regressions. In addition to this PR support for reading thin archives needs to be added (rust-lang#107407) to fix all known regressions.

Fixes rust-lang#107495
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Mar 20, 2024
@GuillaumeGomez
Rollup merge of rust-lang#122723 - bjorn3:archive_writer_fixes, r=nne…
8c991eb 
…thercote

Use same file permissions for ar_archive_writer as the LLVM archive writer

This is required to switch to ar_archive_writer in the future without regressions. In addition to this PR support for reading thin archives needs to be added (rust-lang#107407) to fix all known regressions.

Fixes rust-lang#107495
@bjorn3
Copy link
Member Author

bjorn3 commented Mar 28, 2024

Object now supports reading thin archives. Waiting for a release to wire it up in rustc.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Apr 17, 2024
@matthiaskrgr
Rollup merge of rust-lang#122723 - bjorn3:archive_writer_fixes, r=nne…
d5258af 
…thercote

Use same file permissions for ar_archive_writer as the LLVM archive writer

This is required to switch to ar_archive_writer in the future without regressions. In addition to this PR support for reading thin archives needs to be added (rust-lang#107407) to fix all known regressions.

Fixes rust-lang#107495
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Apr 17, 2024
@rust-timer
Unrolled build for rust-lang#122723
c20c552 
Rollup merge of rust-lang#122723 - bjorn3:archive_writer_fixes, r=nnethercote

Use same file permissions for ar_archive_writer as the LLVM archive writer

This is required to switch to ar_archive_writer in the future without regressions. In addition to this PR support for reading thin archives needs to be added (rust-lang#107407) to fix all known regressions.

Fixes rust-lang#107495
RalfJung pushed a commit to RalfJung/miri that referenced this issue Apr 17, 2024
@matthiaskrgr
Rollup merge of #122723 - bjorn3:archive_writer_fixes, r=nnethercote
2bffbfe 
Use same file permissions for ar_archive_writer as the LLVM archive writer

This is required to switch to ar_archive_writer in the future without regressions. In addition to this PR support for reading thin archives needs to be added (rust-lang/rust#107407) to fix all known regressions.

Fixes rust-lang/rust#107495
@bjorn3 bjorn3 mentioned this issue Aug 10, 2024
Merged
@bjorn3
Copy link
Member Author

bjorn3 commented Aug 10, 2024

#128936 implements this.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 12, 2024
@matthiaskrgr
Rollup merge of rust-lang#128936 - bjorn3:fix_thin_archive_reading, r…
62fddf1 
…=jieyouxu

Support reading thin archives in ArArchiveBuilder

And switch to using ArArchiveBuilder with the LLVM backend too now that all regressions are fixed.

Fixes rust-lang#107407
Fixes rust-lang#107162
rust-lang#107495 has been fixed in a previous PR already.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 12, 2024
@matthiaskrgr
Rollup merge of rust-lang#128936 - bjorn3:fix_thin_archive_reading, r…
530f481 
…=jieyouxu

Support reading thin archives in ArArchiveBuilder

And switch to using ArArchiveBuilder with the LLVM backend too now that all regressions are fixed.

Fixes rust-lang#107407
Fixes rust-lang#107162
rust-lang#107495 has been fixed in a previous PR already.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 12, 2024
@matthiaskrgr
Rollup merge of rust-lang#128936 - bjorn3:fix_thin_archive_reading, r…
f73d4d8 
…=jieyouxu

Support reading thin archives in ArArchiveBuilder

And switch to using ArArchiveBuilder with the LLVM backend too now that all regressions are fixed.

Fixes rust-lang#107407
Fixes rust-lang#107162
rust-lang#107495 has been fixed in a previous PR already.
bors added a commit to rust-lang-ci/rust that referenced this issue Aug 14, 2024
@bors
Auto merge of rust-lang#128936 - bjorn3:fix_thin_archive_reading, r=<…
adcf44d 
…try>

Support reading thin archives in ArArchiveBuilder

And switch to using ArArchiveBuilder with the LLVM backend too now that all regressions are fixed.

Fixes rust-lang#107407
Fixes rust-lang#107162
rust-lang#107495 has been fixed in a previous PR already.

try-job: dist-aarch64-msvc
bors added a commit to rust-lang-ci/rust that referenced this issue Aug 15, 2024
@bors
Auto merge of rust-lang#128936 - bjorn3:fix_thin_archive_reading, r=j…
57ad5b9 
…ieyouxu

Support reading thin archives in ArArchiveBuilder

And switch to using ArArchiveBuilder with the LLVM backend too now that all regressions are fixed.

Fixes rust-lang#107407
Fixes rust-lang#107162
rust-lang#107495 has been fixed in a previous PR already.
@bors bors closed this as completed in d2b5aa6 Aug 15, 2024
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Aug 17, 2024
@bors
Auto merge of #128936 - bjorn3:fix_thin_archive_reading, r=jieyouxu
a04ed69 
Support reading thin archives in ArArchiveBuilder

And switch to using ArArchiveBuilder with the LLVM backend too now that all regressions are fixed.

Fixes rust-lang/rust#107407
Fixes rust-lang/rust#107162
rust-lang/rust#107495 has been fixed in a previous PR already.
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Aug 29, 2024
@bors
Auto merge of #128936 - bjorn3:fix_thin_archive_reading, r=jieyouxu
413e862 
Support reading thin archives in ArArchiveBuilder

And switch to using ArArchiveBuilder with the LLVM backend too now that all regressions are fixed.

Fixes rust-lang/rust#107407
Fixes rust-lang/rust#107162
rust-lang/rust#107495 has been fixed in a previous PR already.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linkage Area: linking into static, shared libraries and binaries C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support reading thin archives in ArArchiveBuilder bjorn3/rust
2 participants
@ChrisDenton @bjorn3