Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable debuginfo tests on Android #10381

Open
yichoi opened this issue Nov 9, 2013 · 9 comments
Open

Re-enable debuginfo tests on Android #10381

yichoi opened this issue Nov 9, 2013 · 9 comments
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. O-android Operating system: Android

Comments

@yichoi
Copy link
Contributor

yichoi commented Nov 9, 2013 •
edited by wesleywiser
Loading

Some debuginfo tests were disabled when running on Android when we added support for running tests on the Android bot (#9120). We should try to enable all debuginfo on Android. (See the results of https://cs.github.com/rust-lang/rust?q=ignore-android%20path%3A%2F%5Esrc%5C%2Ftest%5C%2Fdebuginfo%5C%2F%2F for which tests are disabled)

Debugging with gdb on android target works differently from debugging with gdb on linux.

There are two options however it is not high priority

  • we can modify android gdb to work like linux gdb
  • we can modify debug-info to work with android gdb
@jdm
Copy link
Contributor

jdm commented Nov 9, 2013

What are the differences between android and linux gdb?

@yichoi
Copy link
Contributor Author

yichoi commented Nov 10, 2013

some gdb command works on linux gdb properly but exits without error message on android gdb.

brson added a commit to brson/rust that referenced this issue Dec 14, 2013
@brson
Ignore failing Android debug-info tests. rust-lang#10381
0b69bc9
@flaper87
Copy link
Contributor

Triage: I believe this is still an issue since the debug-info tests are still being ignored for android

@ejjeong ejjeong mentioned this issue Jan 30, 2015
Merged
bors added a commit that referenced this issue Feb 4, 2015
@bors
Auto merge of #21774 - ejjeong:enable-test-for-android, r=alexcrichton
9fd1a97 
- Now "make check-stage2-T-aarch64-linux-android-H-x86_64-unknown-linux-gnu" works (#21773)
- Fix & enable debuginfo tests for android (#10381)
- Fix & enable more tests for android (both for arm/aarch64)
- Enable many already-pass tests on android (both for arm/aarch64)
bors added a commit that referenced this issue Feb 17, 2015
@bors
Auto merge of #21774 - ejjeong:enable-test-for-android, r=alexcrichton
6c065fc 
- Now "make check-stage2-T-aarch64-linux-android-H-x86_64-unknown-linux-gnu" works (#21773)
- Fix & enable debuginfo tests for android (#10381)
- Fix & enable more tests for android (both for arm/aarch64)
- Enable many already-pass tests on android (both for arm/aarch64)
@sanxiyn
Copy link
Member

sanxiyn commented Mar 16, 2015

Fixed in #21774.

@sanxiyn sanxiyn closed this as completed Mar 16, 2015
tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
rust-lang#10381: Warnings
63293d8
tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
Re-enable tests on Android
4d2247d 
Closes rust-lang#10381.
tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
rust-lang#10381: Warnings
ad0785f
tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
Re-enable tests on Android
e87817c 
Closes rust-lang#10381.
tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
rust-lang#10381: Warnings
d0c0e0b
tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
Re-enable tests on Android
24d811e 
Closes rust-lang#10381.
tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
rust-lang#10381: Warnings
18f2ec1
tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
Re-enable tests on Android
46afab4 
Closes rust-lang#10381.
tamird added a commit to tamird/rust that referenced this issue Apr 23, 2015
@tamird
rust-lang#10381: Warnings
c746030
tamird added a commit to tamird/rust that referenced this issue Apr 23, 2015
@tamird
Re-enable tests on Android
fde30f1 
Closes rust-lang#10381.
tamird added a commit to tamird/rust that referenced this issue Apr 24, 2015
@tamird
rust-lang#10381: Warnings
5ded8a8
tamird added a commit to tamird/rust that referenced this issue Apr 24, 2015
@tamird
Re-enable tests on Android
3591e44 
Closes rust-lang#10381.
tamird added a commit to tamird/rust that referenced this issue Apr 25, 2015
@tamird
rust-lang#10381: Warnings
08cd7e2
tamird added a commit to tamird/rust that referenced this issue Apr 25, 2015
@tamird
Re-enable tests on Android
a5e6386 
Closes rust-lang#10381.
@tamird tamird mentioned this issue Apr 29, 2015
Merged
tamird added a commit to tamird/rust that referenced this issue Apr 29, 2015
@tamird
rust-lang#10381: Warnings
54de911
tamird added a commit to tamird/rust that referenced this issue Apr 29, 2015
@tamird
Re-enable tests on Android
698fcea 
Closes rust-lang#10381.
@alexcrichton alexcrichton reopened this Apr 29, 2015
@alexcrichton
Copy link
Member

(a few still ignored)

tamird added a commit to tamird/rust that referenced this issue Apr 29, 2015
@tamird
Re-enable tests on Android
8cdfc8f 
Addresses part of rust-lang#10381.
@steveklabnik
Copy link
Member

Triage: as far as I know, this is still true.

@Mark-Simulacrum Mark-Simulacrum added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 19, 2017
@steveklabnik
Copy link
Member

Triage: no change

@wesleywiser
Copy link
Member

Visited during wg-debugging triage. We still have 11 tests that // ignore-android https://cs.github.com/rust-lang/rust?q=ignore-android%20path%3A%2F%5Esrc%5C%2Ftest%5C%2Fdebuginfo%5C%2F%2F

@wesleywiser wesleywiser changed the title fix to pass test/debug-info/* on android Re-enable debuginfo tests on Android Aug 15, 2022
@bors bors closed this as completed in 574c8ae Feb 26, 2023
@wesleywiser
Copy link
Member

Looks like this was inadvertently closed.

@wesleywiser wesleywiser reopened this Apr 12, 2023
@saethlin saethlin mentioned this issue Aug 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. O-android Operating system: Android
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@flaper87 @jdm @steveklabnik @sanxiyn @alexcrichton @wesleywiser @michaelwoerister @yichoi @Mark-Simulacrum