Skip to content

Commit

Permalink
Rollup merge of #114539 - Enselic:unneeded-fixme, r=ehuss
Browse files Browse the repository at this point in the history
linkchecker: Remove unneeded FIXME about intra-doc links

It was added by #77971 but the adder [proposed](#77971 (comment)) that the added code is a good fallback to have in case rustdoc gets buggy, and I agree. So remove the FIXME.

This PR is part of #44366 which is E-help-wanted.

r? `@jyn514` since you added the FIXME

`@rustbot` label T-dev-tools
  • Loading branch information
matthiaskrgr authored Aug 6, 2023
2 parents 0c98f15 + cf08888 commit f542163
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/tools/linkchecker/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,6 @@ impl Checker {
return;
}
// Search for intra-doc links that rustdoc didn't warn about
// FIXME(#77199, 77200) Rustdoc should just warn about these directly.
// NOTE: only looks at one line at a time; in practice this should find most links
for (i, line) in source.lines().enumerate() {
for broken_link in BROKEN_INTRA_DOC_LINK.captures_iter(line) {
Expand Down

0 comments on commit f542163

Please sign in to comment.