fail on component linking failures

Signed-off-by: onur-ozkan <[email protected]>
rust-lang · Jun 30, 2024 · ee92e6b · ee92e6b
1 parent f4fdfad
commit ee92e6b
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/bootstrap/src/core/build_steps/compile.rs b/src/bootstrap/src/core/build_steps/compile.rs
@@ -1624,17 +1624,18 @@ impl Step for Sysroot {
         let sysroot_lib_rustlib_src_rust = sysroot_lib_rustlib_src.join("rust");
         if let Err(e) = symlink_dir(&builder.config, &builder.src, &sysroot_lib_rustlib_src_rust) {
             eprintln!(
-                "WARNING: creating symbolic link `{}` to `{}` failed with {}",
+                "ERROR: creating symbolic link `{}` to `{}` failed with {}",
                 sysroot_lib_rustlib_src_rust.display(),
                 builder.src.display(),
                 e,
             );
             if builder.config.rust_remap_debuginfo {
                 eprintln!(
-                    "WARNING: some `tests/ui` tests will fail when lacking `{}`",
+                    "ERROR: some `tests/ui` tests will fail when lacking `{}`",
                     sysroot_lib_rustlib_src_rust.display(),
                 );
             }
+            build_helper::exit!(1);
         }
 
         // Unlike rust-src component, we have to handle rustc-src a bit differently, otherwise
@@ -1654,11 +1655,13 @@ impl Step for Sysroot {
                 symlink_dir(&builder.config, &builder.src, &sysroot_lib_rustlib_rustcsrc_rust)
             {
                 eprintln!(
-                "WARNING: creating symbolic link `{}` to `{}` failed with {}",
+                    "ERROR: creating symbolic link `{}` to `{}` failed with {}",
                     sysroot_lib_rustlib_rustcsrc_rust.display(),
                     builder.src.display(),
                     e,
                 );
+                build_helper::exit!(1);
+            }
         }
 
         sysroot