Skip to content

Commit

Permalink
auto merge of #17415 : jakub-/rust/issue-17383, r=huonw
Browse files Browse the repository at this point in the history
Fixes #17383.
  • Loading branch information
bors committed Sep 21, 2014
2 parents 9c39b6c + 3514737 commit d7e1bb5
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 5 deletions.
12 changes: 7 additions & 5 deletions src/libsyntax/parse/parser.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5069,7 +5069,7 @@ impl<'a> Parser<'a> {
fn parse_enum_def(&mut self, _generics: &ast::Generics) -> EnumDef {
let mut variants = Vec::new();
let mut all_nullary = true;
let mut have_disr = false;
let mut any_disr = None;
while self.token != token::RBRACE {
let variant_attrs = self.parse_outer_attributes();
let vlo = self.span.lo;
Expand Down Expand Up @@ -5101,8 +5101,8 @@ impl<'a> Parser<'a> {
}
kind = TupleVariantKind(args);
} else if self.eat(&token::EQ) {
have_disr = true;
disr_expr = Some(self.parse_expr());
any_disr = disr_expr.as_ref().map(|expr| expr.span);
kind = TupleVariantKind(args);
} else {
kind = TupleVariantKind(Vec::new());
Expand All @@ -5121,9 +5121,11 @@ impl<'a> Parser<'a> {
if !self.eat(&token::COMMA) { break; }
}
self.expect(&token::RBRACE);
if have_disr && !all_nullary {
self.fatal("discriminator values can only be used with a c-like \
enum");
match any_disr {
Some(disr_span) if !all_nullary =>
self.span_err(disr_span,
"discriminator values can only be used with a c-like enum"),
_ => ()
}

ast::EnumDef { variants: variants }
Expand Down
18 changes: 18 additions & 0 deletions src/test/compile-fail/issue-17383.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

enum X {
A =
b'a' //~ ERROR discriminator values can only be used with a c-like enum
,
B(int)
}

fn main() {}

0 comments on commit d7e1bb5

Please sign in to comment.