-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
librustc_mir: Fix ICE with slice patterns
If a match arm does not include all fields in a structure and a later pattern includes a field that is an array, we will attempt to use the array type from the prior arm. When calculating the field type, treat a array of an unknown size as a TyErr.
- Loading branch information
1 parent
0c91f3d
commit d6c1919
Showing
3 changed files
with
63 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
#![crate_type="lib"] | ||
#![deny(unreachable_patterns)] | ||
|
||
mod test_struct { | ||
// Test the exact copy of the minimal example | ||
// posted in the issue. | ||
pub struct Punned { | ||
foo: [u8; 1], | ||
bar: [u8; 1], | ||
} | ||
|
||
pub fn test(punned: Punned) { | ||
match punned { | ||
Punned { foo: [_], .. } => println!("foo"), | ||
Punned { bar: [_], .. } => println!("bar"), | ||
//~^ ERROR unreachable pattern [unreachable_patterns] | ||
} | ||
} | ||
} | ||
|
||
mod test_union { | ||
// Test the same thing using a union. | ||
pub union Punned { | ||
foo: [u8; 1], | ||
bar: [u8; 1], | ||
} | ||
|
||
pub fn test(punned: Punned) { | ||
match punned { | ||
Punned { foo: [_] } => println!("foo"), | ||
Punned { bar: [_] } => println!("bar"), | ||
//~^ ERROR unreachable pattern [unreachable_patterns] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
error: unreachable pattern | ||
--> $DIR/issue-57472.rs:15:13 | ||
| | ||
LL | Punned { bar: [_], .. } => println!("bar"), | ||
| ^^^^^^^^^^^^^^^^^^^^^^^ | ||
| | ||
note: lint level defined here | ||
--> $DIR/issue-57472.rs:2:9 | ||
| | ||
LL | #![deny(unreachable_patterns)] | ||
| ^^^^^^^^^^^^^^^^^^^^ | ||
|
||
error: unreachable pattern | ||
--> $DIR/issue-57472.rs:31:13 | ||
| | ||
LL | Punned { bar: [_] } => println!("bar"), | ||
| ^^^^^^^^^^^^^^^^^^^ | ||
|
||
error: aborting due to 2 previous errors | ||
|