Skip to content

Commit

Permalink
Auto merge of #26558 - nham:fix_24357, r=alexcrichton
Browse files Browse the repository at this point in the history
Fixes #24357.

Also adds a (totally separate) regression test, which

Closes #18119
  • Loading branch information
bors committed Jun 25, 2015
2 parents 688b623 + db9af26 commit b213c94
Show file tree
Hide file tree
Showing 3 changed files with 41 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/librustc_borrowck/borrowck/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,7 @@ impl<'a, 'tcx> BorrowckCtxt<'a, 'tcx> {
has type `{}`, which is {}",
ol,
moved_lp_msg,
expr_ty,
moved_lp.ty,
suggestion));
self.tcx.sess.fileline_help(expr_span, help);
}
Expand Down
22 changes: 22 additions & 0 deletions src/test/compile-fail/issue-18119.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

const X: u8 = 1;
static Y: u8 = 1;
fn foo() {}

impl X {}
//~^ ERROR use of undeclared type name `X`
impl Y {}
//~^ ERROR use of undeclared type name `Y`
impl foo {}
//~^ ERROR use of undeclared type name `foo`

fn main() {}
18 changes: 18 additions & 0 deletions src/test/compile-fail/issue-24357.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

struct NoCopy;
fn main() {
let x = NoCopy;
let f = move || { let y = x; };
//~^ NOTE `x` moved into closure environment here because it has type `NoCopy`
let z = x;
//~^ ERROR use of moved value: `x`
}

0 comments on commit b213c94

Please sign in to comment.